From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Yufeng Zhang <Yufeng.Zhang@arm.com>,
GDB Patches <gdb-patches@sourceware.org>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
Date: Sat, 28 Dec 2013 03:35:00 -0000 [thread overview]
Message-ID: <20131228033514.GE4532@adacore.com> (raw)
In-Reply-To: <m3ioufjxk2.fsf@redhat.com>
> 2013-12-23 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * NEWS: Mention SystemTap SDT probe support for AArch64 GNU/Linux.
> * aarch64-linux-tdep.c: Include necessary headers for parsing of
> SystemTap SDT probes.
> (aarch64_stap_is_single_operand): New function.
> (aarch64_stap_parse_special_token): Likewise.
> (aarch64_linux_init_abi): Declare SystemTap SDT probe argument
> prefixes and suffixes. Initialize gdbarch with them.
First of all, thanks to Yufeng and Marcus for reviewing the patch.
That was very useful.
The patch is therefore approved, with one small request:
> }
>
> +static int
> +aarch64_stap_is_single_operand (struct gdbarch *gdbarch, const char *s)
> +{
> + return (*s == '#' || isdigit (*s) /* Literal number. */
> + || *s == '[' /* Register indirection. */
> + || isalpha (*s)); /* Register value. */
> +}
Can you document this function?
Thank you,
--
Joel
next prev parent reply other threads:[~2013-12-28 3:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 22:20 Sergio Durigan Junior
2013-12-20 3:08 ` Sergio Durigan Junior
2013-12-23 16:52 ` Yufeng Zhang
2013-12-23 17:18 ` Sergio Durigan Junior
2013-12-23 17:48 ` Yufeng Zhang
2013-12-28 3:35 ` Joel Brobecker [this message]
2013-12-28 16:22 ` Sergio Durigan Junior
2013-12-28 23:36 ` Sergio Durigan Junior
2013-12-30 2:57 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131228033514.GE4532@adacore.com \
--to=brobecker@adacore.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Yufeng.Zhang@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).