public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Doug Evans <dje@google.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Change coding style rule: 80 column "hard limit" for ChangeLogs
Date: Sun, 05 Jan 2014 04:00:00 -0000	[thread overview]
Message-ID: <20140105040005.GA3802@adacore.com> (raw)
In-Reply-To: <83bnzsw6ro.fsf@gnu.org>

> AFAIK, that's because this is the default in Emacs's commands that
> manipulate ChangeLog entries.  Here:
> 
>   (define-derived-mode change-log-mode text-mode "Change Log"
>     "Major mode for editing change logs; like Indented Text mode.
>   Prevents numeric backups and sets `left-margin' to 8 and `fill-column' to 74.
>   New log entries are usually made with \\[add-change-log-entry] or \\[add-change-log-entry-other-window].
>   Each entry behaves as a paragraph, and the entries for one day as a page.
>   Runs `change-log-mode-hook'.
>   \n\\{change-log-mode-map}"
>     (setq left-margin 8
> 	  fill-column 74   <<<<<<<<<<<<<<<<<<<<<<<<<<<<<
> 	  indent-tabs-mode t
> 	  tab-width 8
> 	  show-trailing-whitespace t)

We can transparently override it, I think, since our ChangeLog entries have:

> Local Variables:
> mode: change-log
> left-margin: 8
> fill-column: 74
> version-control: never
> coding: utf-8
> End:

(to be confirmed, since I am no longer an emacs user).

That being said, and fwiw only, I subscribe to the idea that 80
characters is a little bit on the long side. I think it's a good
idea to have one limit, and one limit only, but I'd prefer to
make it closer to 70 than 80 - maybe 74 could be a good compromise.
Ie, raise the soft-limit for the code to 74, leave the hard-limit
to 80, and thus keep ChangeLogs as is.

Other than the opinion above, it's not really all that important to me.
So I'm good with whatever reasonable limit the group decides. We just
need to make sure we document the decision, with reference to the
discussion.

-- 
Joel

  reply	other threads:[~2014-01-05  4:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-03 22:50 Doug Evans
2014-01-04  7:22 ` Eli Zaretskii
2014-01-05  4:00   ` Joel Brobecker [this message]
2014-01-06 17:56     ` Doug Evans
2014-01-08 11:45       ` Joel Brobecker
2014-01-08 20:21         ` Doug Evans
2014-01-08 21:42           ` Sergio Durigan Junior
2014-01-09  2:34           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140105040005.GA3802@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).