From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13135 invoked by alias); 5 Jan 2014 04:00:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13089 invoked by uid 89); 5 Jan 2014 04:00:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 05 Jan 2014 04:00:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8C6971165A5; Sat, 4 Jan 2014 23:00:10 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KsElh1Z1HRmj; Sat, 4 Jan 2014 23:00:10 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 21E0A1165A0; Sat, 4 Jan 2014 23:00:10 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E013EE1447; Sun, 5 Jan 2014 08:00:05 +0400 (RET) Date: Sun, 05 Jan 2014 04:00:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: Doug Evans , gdb-patches@sourceware.org Subject: Re: [RFC] Change coding style rule: 80 column "hard limit" for ChangeLogs Message-ID: <20140105040005.GA3802@adacore.com> References: <83bnzsw6ro.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83bnzsw6ro.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00032.txt.bz2 > AFAIK, that's because this is the default in Emacs's commands that > manipulate ChangeLog entries. Here: > > (define-derived-mode change-log-mode text-mode "Change Log" > "Major mode for editing change logs; like Indented Text mode. > Prevents numeric backups and sets `left-margin' to 8 and `fill-column' to 74. > New log entries are usually made with \\[add-change-log-entry] or \\[add-change-log-entry-other-window]. > Each entry behaves as a paragraph, and the entries for one day as a page. > Runs `change-log-mode-hook'. > \n\\{change-log-mode-map}" > (setq left-margin 8 > fill-column 74 <<<<<<<<<<<<<<<<<<<<<<<<<<<<< > indent-tabs-mode t > tab-width 8 > show-trailing-whitespace t) We can transparently override it, I think, since our ChangeLog entries have: > Local Variables: > mode: change-log > left-margin: 8 > fill-column: 74 > version-control: never > coding: utf-8 > End: (to be confirmed, since I am no longer an emacs user). That being said, and fwiw only, I subscribe to the idea that 80 characters is a little bit on the long side. I think it's a good idea to have one limit, and one limit only, but I'd prefer to make it closer to 70 than 80 - maybe 74 could be a good compromise. Ie, raise the soft-limit for the code to 74, leave the hard-limit to 80, and thus keep ChangeLogs as is. Other than the opinion above, it's not really all that important to me. So I'm good with whatever reasonable limit the group decides. We just need to make sure we document the decision, with reference to the discussion. -- Joel