From: Joel Brobecker <brobecker@adacore.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add d_main_name to dlang.c
Date: Tue, 07 Jan 2014 10:44:00 -0000 [thread overview]
Message-ID: <20140107104423.GI3802@adacore.com> (raw)
In-Reply-To: <CABOHX+dV-AQ4SEwywv=OU2Wit62yYLz9BKMs4KcqBT=JNYGdtQ@mail.gmail.com>
> By the way, would it be best to split this up into smaller changes?
If they can and should be applied independently, most definitely.
This has two strong advantages I can think of:
- In case problem requiring a revert (I am not speaking of your
patch!), it allows us to revert the one patch that causes problem,
while keepping the rest;
- It makes it much easier to review the patches, first because
they are easier to digest, and second because we can review
them one at a time, making it more likely for us to find the time
to do so.
--
Joel
prev parent reply other threads:[~2014-01-07 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 1:53 Iain Buclaw
2013-11-19 16:09 ` Tom Tromey
2013-11-19 17:50 ` Iain Buclaw
2013-11-19 18:06 ` Tom Tromey
2013-11-19 21:05 ` Pierre Muller
[not found] ` <39451.43601527$1384894769@news.gmane.org>
2013-11-19 21:08 ` Tom Tromey
2014-01-03 18:18 ` Iain Buclaw
2014-01-07 9:53 ` Iain Buclaw
2014-01-07 10:44 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107104423.GI3802@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ibuclaw@gdcproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).