From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26766 invoked by alias); 7 Jan 2014 10:44:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26754 invoked by uid 89); 7 Jan 2014 10:44:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 07 Jan 2014 10:44:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6D7AA116414; Tue, 7 Jan 2014 05:44:26 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Mc92eryNVtu7; Tue, 7 Jan 2014 05:44:26 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 05AA411640D; Tue, 7 Jan 2014 05:44:26 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 47593E02E6; Tue, 7 Jan 2014 14:44:23 +0400 (RET) Date: Tue, 07 Jan 2014 10:44:00 -0000 From: Joel Brobecker To: Iain Buclaw Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add d_main_name to dlang.c Message-ID: <20140107104423.GI3802@adacore.com> References: <87mwl0mlsa.fsf@fleche.redhat.com> <874n78mge2.fsf@fleche.redhat.com> <39451.43601527$1384894769@news.gmane.org> <87bo1gksu3.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00133.txt.bz2 > By the way, would it be best to split this up into smaller changes? If they can and should be applied independently, most definitely. This has two strong advantages I can think of: - In case problem requiring a revert (I am not speaking of your patch!), it allows us to revert the one patch that causes problem, while keepping the rest; - It makes it much easier to review the patches, first because they are easier to digest, and second because we can review them one at a time, making it more likely for us to find the time to do so. -- Joel