From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32108 invoked by alias); 8 Jan 2014 07:49:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32096 invoked by uid 89); 8 Jan 2014 07:49:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 08 Jan 2014 07:49:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 53EC91162F7; Wed, 8 Jan 2014 02:49:16 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id T84fc5kEgsgQ; Wed, 8 Jan 2014 02:49:16 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EBC6C1162F1; Wed, 8 Jan 2014 02:49:15 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A7344E00AD; Wed, 8 Jan 2014 11:49:13 +0400 (RET) Date: Wed, 08 Jan 2014 07:49:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Use target_xfer_partial_ftype for rs6000_xfer_shared_libraries Message-ID: <20140108074913.GJ3802@adacore.com> References: <1389166060-434-1-git-send-email-yao@codesourcery.com> <1389166060-434-2-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1389166060-434-2-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00181.txt.bz2 > 2014-01-08 Yao Qi > > * rs6000-nat.c (rs6000_xfer_shared_libraries): Use > target_xfer_partial_ftype. This one is a nice cleanup on its own, and can go in now, regardless of the rest of the patch series. You can treat other changes of this kind as obvious. An option, if we want to get rid of the advance declaration, is to move the function's body ahead of rs6000_xfer_partial (not sure if that triggers other issues, though). > --- > gdb/rs6000-nat.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/gdb/rs6000-nat.c b/gdb/rs6000-nat.c > index a297376..da17b94 100644 > --- a/gdb/rs6000-nat.c > +++ b/gdb/rs6000-nat.c > @@ -79,10 +79,7 @@ > > static void exec_one_dummy_insn (struct regcache *); > > -static LONGEST rs6000_xfer_shared_libraries > - (struct target_ops *ops, enum target_object object, > - const char *annex, gdb_byte *readbuf, const gdb_byte *writebuf, > - ULONGEST offset, LONGEST len); > +static target_xfer_partial_ftype rs6000_xfer_shared_libraries; > > /* Given REGNO, a gdb register number, return the corresponding > number suitable for use as a ptrace() parameter. Return -1 if > -- > 1.7.7.6 -- Joel