From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32485 invoked by alias); 8 Jan 2014 11:35:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32475 invoked by uid 89); 8 Jan 2014 11:35:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 08 Jan 2014 11:35:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BBFC21166EB; Wed, 8 Jan 2014 06:35:20 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id um1gRnERbeqo; Wed, 8 Jan 2014 06:35:20 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 61D481166CC; Wed, 8 Jan 2014 06:35:20 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6FBA0E09FF; Wed, 8 Jan 2014 15:35:17 +0400 (RET) Date: Wed, 08 Jan 2014 11:35:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [commit/Ada] General ada-valprint improvements Message-ID: <20140108113517.GL3802@adacore.com> References: <1389068515-10129-1-git-send-email-brobecker@adacore.com> <87r48jhfa8.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r48jhfa8.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00196.txt.bz2 > I'm curious to know what differences you are thinking of. Sure! valprint.c:val_print does a few things that value_print does not. For instance, it handles TYPE_STUB, options->summary, etc. On the Ada side, it's ada_value_print that does a few things that ada_val_print does not. For instance, it prints some information about the entity's type before printing the entity's value. For Ada, I think untangling the extra stuff in ada_value_print could be done by simply splitting it in two. For val_print, I haven't even really looked at it yet. Just one of those many things at the back of my mind. -- Joel