From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7267 invoked by alias); 11 Jan 2014 03:02:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7250 invoked by uid 89); 11 Jan 2014 03:02:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 11 Jan 2014 03:02:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4FCA2116768; Fri, 10 Jan 2014 22:02:04 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id syTKcixFBkya; Fri, 10 Jan 2014 22:02:04 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D90E5116765; Fri, 10 Jan 2014 22:02:03 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5C973E129F; Sat, 11 Jan 2014 07:02:00 +0400 (RET) Date: Sat, 11 Jan 2014 03:02:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: GDB Patches , Mark Kettenis Subject: Re: [PATCH] Split i386_stap_parse_special_token into smaller functions Message-ID: <20140111030200.GD4762@adacore.com> References: <20131230031112.GC6055@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00304.txt.bz2 > >> FWIW, this patch looks good to me, and it is IMO a nice improvement > >> over the current state. But i386-tdep.c is usually under Mark's > >> responsibility, so let's give him a little bit of time to reply > >> as well. > > > > Ping. > > Ping^2. > > This patch is pretty simple IMO (just code movement), so maybe it could > be reviewed by some other maintainer and maybe approved? It's holding a > fix for a bug :-). Go ahead and push. I reviewed the patch a second time, and it still looks good to me. Thank you, Sergio. -- Joel