From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15396 invoked by alias); 14 Jan 2014 17:19:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15383 invoked by uid 89); 14 Jan 2014 17:19:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 14 Jan 2014 17:19:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 04524116167; Tue, 14 Jan 2014 12:19:08 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EXGoMQKi6XSV; Tue, 14 Jan 2014 12:19:07 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9B6E711615A; Tue, 14 Jan 2014 12:19:07 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 07FBAE0360; Tue, 14 Jan 2014 21:18:59 +0400 (RET) Date: Tue, 14 Jan 2014 17:19:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [RFC 03/32] introduce async_callback_ftype Message-ID: <20140114171858.GG4762@adacore.com> References: <1389640367-5571-1-git-send-email-tromey@redhat.com> <1389640367-5571-4-git-send-email-tromey@redhat.com> <52D512FB.7010006@redhat.com> <20140114105012.GF4762@adacore.com> <87a9eyy55d.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a9eyy55d.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00449.txt.bz2 > /* The type of the callback to the to_async method. */ > > typedef void async_callback_ftype (enum inferior_event_type event_type, > void *context); > "context" is used in several places related to this. OTOH the only > non-NULL function pointer ever passed to to_async is > 'inferior_event_handler', which names the second argument "client_data". > I found them equally clear; particularly once I noticed that all > existing calls pass context==NULL :) That looks good to me, thank you! > As for documentation, I think the docs should be comments before each > to_* method. That works for me. > target.h has been laxly maintained in this regard. We're getting better at this, though :-). I think we generally understand better the value of providing good documentation. Thanks, Tom. -- Joel