public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] AArch64: gdb.base/float.exp: Fix `info float' test
Date: Wed, 15 Jan 2014 03:45:00 -0000	[thread overview]
Message-ID: <20140115034527.GH4762@adacore.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1401142254410.6899@tp.orcam.me.uk>

> 2014-01-14  Maciej W. Rozycki  <macro@codesourcery.com>
> 
> 	gdb/testsuite/
> 	* gdb.base/float.exp: Handle "aarch64*-*-*" targets.

FWIW, no problem with the patch. But I don't know AArch64.
Does it always have an FPU? Otherwise, we perhaps should look at
what is being done for arm-*?

> 
>   Maciej
> 
> gdb-test-aarch64-info-float.diff
> Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.base/float.exp
> ===================================================================
> --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.base/float.exp	2014-01-14 22:12:55.798957511 +0000
> +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.base/float.exp	2014-01-14 22:38:14.458923719 +0000
> @@ -36,7 +36,9 @@ if ![runto_main] then {
>  
>  # Test "info float".
>  
> -if { [istarget "alpha*-*-*"] } then {
> +if { [istarget "aarch64*-*-*"] } then {
> +    gdb_test "info float" "d0.*d1.*d31.*s0.*s1.*s31.*" "info float"
> +} elseif { [istarget "alpha*-*-*"] } then {
>      gdb_test "info float" "f0.*" "info float"
>  } elseif { [istarget "arm*-*-*"] } then {
>      gdb_test_multiple "info float" "info float" {

-- 
Joel

  reply	other threads:[~2014-01-15  3:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 23:04 Maciej W. Rozycki
2014-01-15  3:45 ` Joel Brobecker [this message]
2014-01-15  8:27   ` Maciej W. Rozycki
2014-01-15  8:57   ` Marcus Shawcroft
2014-01-15  9:55     ` Joel Brobecker
2014-01-15 22:22       ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140115034527.GH4762@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).