From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Michael Eager <eager@eagerm.com>,
gdb-patches ml <gdb-patches@sourceware.org>,
Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH] Regression setting breakpoint
Date: Thu, 16 Jan 2014 05:37:00 -0000 [thread overview]
Message-ID: <20140116053702.GR4762@adacore.com> (raw)
In-Reply-To: <m361pkbiwk.fsf@redhat.com>
> Not really a code review, but the ChangeLog entries should be of the
> form:
>
> 2014-01-16 Your Name <you@email.com>
>
> * file.c (function): What changed.
FWIW, I have been using:
| gdb/ChangeLog:
|
| * file.c (function): What changed.
|
| gdb/testsuite/ChangeLog:
|
| * gdb.base/file.exp: Bla bla bla.
Two reasons: It makes it obvious which ChangeLog the entries refer to,
and it avoids the need to put a date in the revision log, which may
become obe due to the time it takes to get the patch in after it is
written.
The format with dates are accepted as well, of course. And I have
seen people add the directory usually on the line just ahead of
the CL entry. Eg:
| gdb/:
| 2014-01-16 Your Name <you@example.com>
--
Joel
next prev parent reply other threads:[~2014-01-16 5:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 20:38 Michael Eager
2014-01-16 5:22 ` Sergio Durigan Junior
2014-01-16 5:37 ` Joel Brobecker [this message]
2014-01-31 16:21 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116053702.GR4762@adacore.com \
--to=brobecker@adacore.com \
--cc=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).