From: Baruch Siach <baruch@tkos.co.il>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: xtensa: fix on 64 bit hosts
Date: Wed, 22 Jan 2014 04:48:00 -0000 [thread overview]
Message-ID: <20140122044836.GL12751@tarshish> (raw)
In-Reply-To: <52D80DC6.5030703@redhat.com>
Hi Pedro,
On Thu, Jan 16, 2014 at 04:50:14PM +0000, Pedro Alves wrote:
> On 01/16/2014 01:02 PM, Baruch Siach wrote:
> > On 64 bit hosts unsigned long is 64 bit. Use uint32_t instead.
> >
> > * xtensa-tdep.h (xtensa_elf_greg_t): Change type to uint32_t
>
> Missing period.
>
> OK (and obvious).
Should I resend?
baruch
> > ---
> > gdb/xtensa-tdep.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gdb/xtensa-tdep.h b/gdb/xtensa-tdep.h
> > index 968b9d2916b7..d7ba5628e42a 100644
> > --- a/gdb/xtensa-tdep.h
> > +++ b/gdb/xtensa-tdep.h
> > @@ -84,7 +84,7 @@ typedef enum
> > /* Xtensa ELF core file register set representation ('.reg' section).
> > Copied from target-side ELF header <xtensa/elf.h>. */
> >
> > -typedef unsigned long xtensa_elf_greg_t;
> > +typedef uint32_t xtensa_elf_greg_t;
> >
> > typedef struct
> > {
> >
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-01-22 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:03 Baruch Siach
2014-01-16 16:50 ` Pedro Alves
2014-01-22 4:48 ` Baruch Siach [this message]
2014-01-22 12:16 ` xtensa-config.c: missing defs.h include Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122044836.GL12751@tarshish \
--to=baruch@tkos.co.il \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).