From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24245 invoked by alias); 22 Jan 2014 04:48:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24232 invoked by uid 89); 22 Jan 2014 04:48:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: mx.tkos.co.il Received: from guitar.tcltek.co.il (HELO mx.tkos.co.il) (192.115.133.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Jan 2014 04:48:41 +0000 Received: from tarshish (unknown [10.0.8.6]) by mx.tkos.co.il (Postfix) with ESMTPSA id 4274D4405F4; Wed, 22 Jan 2014 06:48:38 +0200 (IST) Date: Wed, 22 Jan 2014 04:48:00 -0000 From: Baruch Siach To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: xtensa: fix on 64 bit hosts Message-ID: <20140122044836.GL12751@tarshish> References: <52D80DC6.5030703@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52D80DC6.5030703@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00836.txt.bz2 Hi Pedro, On Thu, Jan 16, 2014 at 04:50:14PM +0000, Pedro Alves wrote: > On 01/16/2014 01:02 PM, Baruch Siach wrote: > > On 64 bit hosts unsigned long is 64 bit. Use uint32_t instead. > > > > * xtensa-tdep.h (xtensa_elf_greg_t): Change type to uint32_t > > Missing period. > > OK (and obvious). Should I resend? baruch > > --- > > gdb/xtensa-tdep.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gdb/xtensa-tdep.h b/gdb/xtensa-tdep.h > > index 968b9d2916b7..d7ba5628e42a 100644 > > --- a/gdb/xtensa-tdep.h > > +++ b/gdb/xtensa-tdep.h > > @@ -84,7 +84,7 @@ typedef enum > > /* Xtensa ELF core file register set representation ('.reg' section). > > Copied from target-side ELF header . */ > > > > -typedef unsigned long xtensa_elf_greg_t; > > +typedef uint32_t xtensa_elf_greg_t; > > > > typedef struct > > { > > -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -