From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Expand documentation of common-utils.h::FUNCTION_NAME
Date: Wed, 22 Jan 2014 04:59:00 -0000 [thread overview]
Message-ID: <20140122045956.GA4762@adacore.com> (raw)
In-Reply-To: <CADPb22Se+Wm_QvD4bk6Qby3zzOjqx6ROkr4aaKqinx_H5qdgtQ@mail.gmail.com>
> > gdb/ChangeLog:
> >
> > * common/common-utils.h (FUNCTION_NAME): Expand the macro's
> > documentation a bit.
> >
> > I would commit on its own, but since I am going to put the next in
> > for the same macro up for review, it's just as easy to make that one
> > wait as well, in case there are comments.
>
> Yeah, I stumbled a bit on this myself.
> It's not clear to me whether not defining it or defining it as NULL
> (and update all current users to deal with that) is better but I went
> with keeping things as they are.
I almost had the same thoughts. I agree that it's just best to let
things as they are until we have evidence that changing them would
be beneficial. The difference is that I was thinking of defining
FUNCTION_NAME to something like "<unknown function>" rather than NULL.
Without more evidence, not clear which would be best...
--
Joel
next prev parent reply other threads:[~2014-01-22 4:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 1:52 New ARI warning Sat Jan 18 01:52:44 UTC 2014 GDB Administrator
2014-01-21 10:36 ` [PATCH 1/2] Expand documentation of common-utils.h::FUNCTION_NAME Joel Brobecker
2014-01-21 10:36 ` [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h Joel Brobecker
2014-01-22 4:44 ` Doug Evans
2014-01-22 4:57 ` Joel Brobecker
2014-01-22 5:12 ` pushed: " Joel Brobecker
2014-01-22 4:41 ` [PATCH 1/2] Expand documentation of common-utils.h::FUNCTION_NAME Doug Evans
2014-01-22 4:59 ` Joel Brobecker [this message]
2014-01-22 5:20 ` Doug Evans
2014-01-22 5:12 ` pushed: " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122045956.GA4762@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).