From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3097 invoked by alias); 11 Apr 2014 21:13:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3087 invoked by uid 89); 11 Apr 2014 21:13:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 11 Apr 2014 21:13:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 53BAB1160F0; Fri, 11 Apr 2014 17:13:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GlGmjeD82FnF; Fri, 11 Apr 2014 17:13:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E21DC1160EB; Fri, 11 Apr 2014 17:13:10 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8A00FE0946; Fri, 11 Apr 2014 14:13:14 -0700 (PDT) Date: Fri, 11 Apr 2014 21:13:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: "Agovic, Sanimir" , "gdb-patches@sourceware.org" Subject: Re: [PATCH v6 00/15] Please have a final look Message-ID: <20140411211314.GO4250@adacore.com> References: <1397133617-26681-1-git-send-email-sanimir.agovic@intel.com> <20140410143915.GD15965@adacore.com> <0377C58828D86C4588AEEC42FC3B85A71D84FE7A@IRSMSX105.ger.corp.intel.com> <53483E24.5060302@redhat.com> <20140411202747.GN4250@adacore.com> <5348518D.8010100@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5348518D.8010100@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-04/txt/msg00223.txt.bz2 > >How come this didn't show up in Sanimir's testing? > > I don't know. Maybe my sandbox is messed up? It *is* Friday afterall! :-) It must be Friday for both of us, then - as I was able to reproduce at least some of the failures. I am testing each patch in sequence and so far, two of them cause additional failures: commit 37c1ab67a35025d37d42c449deab5f254f9f59da Subject: type: add c99 variable length array support This one only causes new failire in gdb.ada commit bcd629a44fff61527430f353cf77e20fe3afc395 Subject: vla: update type from newly created value This one causes new failures in gdb.base, gdb.cp, etc. > >I'm doing a quick round of testing with what's left of my day today, > >but we might have to revert the patch series to allow us more time > >to investigate. > > Would you like me to hold off on committing my c++/16675 patchset? > That touches eval.c:evaluate_subexp_for_sizeof. It's not a huge deal > IMO. A Most of the "conflict" is simply that I chose to refactor > this function a little. [i.e., remove all the "return > value_from_longest" and collect them at the end of the function] You should do whatever is convenient for you, and I will work around it. No reason to inconvenience you further! So, if you are ready, just go ahead and push. I will review the errors and decide from there whether we can wait until early next week to fix them or else if we should revert now. Thanks! -- Joel