* [PATCH] rename "set debugvarobj" to "set debug varobj"
@ 2014-04-29 15:36 Tom Tromey
2014-04-29 16:10 ` Eli Zaretskii
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Tom Tromey @ 2014-04-29 15:36 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
I think "set debugvarobj" has the wrong name.
It ought to be "set debug varobj", like gdb's other debug settings.
This patch makes the change.
I chose not to install deprecated aliases, since this is only a debug
setting; but if someone feels strongly about it I will add them.
Built and regtested on x86-64 Fedora 20.
2014-04-29 Tom Tromey <tromey@redhat.com>
* varobj.c (_initialize_varobj): Rename to "set debug varobj" and
"show debug varobj".
2014-04-29 Tom Tromey <tromey@redhat.com>
* gdb.texinfo (Debugging Output): Rename to "set debug varobj" and
"show debug varobj".
---
gdb/ChangeLog | 5 +++++
gdb/doc/ChangeLog | 5 +++++
gdb/doc/gdb.texinfo | 4 ++--
gdb/varobj.c | 5 +++--
4 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 9d91075..623a954 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -22925,11 +22925,11 @@ message.
@item show debug timestamp
Displays the current state of displaying timestamps with @value{GDBN}
debugging info.
-@item set debugvarobj
+@item set debug varobj
@cindex variable object debugging info
Turns on or off display of @value{GDBN} variable object debugging
info. The default is off.
-@item show debugvarobj
+@item show debug varobj
Displays the current state of displaying @value{GDBN} variable object
debugging info.
@item set debug xml
diff --git a/gdb/varobj.c b/gdb/varobj.c
index 10ef5b7..eab6030 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -2795,17 +2795,18 @@ void
_initialize_varobj (void)
{
int sizeof_table = sizeof (struct vlist *) * VAROBJ_TABLE_SIZE;
+ struct cmd_list_element *c;
varobj_table = xmalloc (sizeof_table);
memset (varobj_table, 0, sizeof_table);
- add_setshow_zuinteger_cmd ("debugvarobj", class_maintenance,
+ add_setshow_zuinteger_cmd ("varobj", class_maintenance,
&varobjdebug,
_("Set varobj debugging."),
_("Show varobj debugging."),
_("When non-zero, varobj debugging is enabled."),
NULL, show_varobjdebug,
- &setlist, &showlist);
+ &setdebuglist, &showdebuglist);
}
/* Invalidate varobj VAR if it is tied to locals and re-create it if it is
--
1.9.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rename "set debugvarobj" to "set debug varobj"
2014-04-29 15:36 [PATCH] rename "set debugvarobj" to "set debug varobj" Tom Tromey
@ 2014-04-29 16:10 ` Eli Zaretskii
2014-04-29 17:58 ` Joel Brobecker
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2014-04-29 16:10 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches, tromey
> From: Tom Tromey <tromey@redhat.com>
> Cc: Tom Tromey <tromey@redhat.com>
> Date: Tue, 29 Apr 2014 09:36:30 -0600
>
> I think "set debugvarobj" has the wrong name.
> It ought to be "set debug varobj", like gdb's other debug settings.
>
> This patch makes the change.
The documentation part is fine with me, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rename "set debugvarobj" to "set debug varobj"
2014-04-29 15:36 [PATCH] rename "set debugvarobj" to "set debug varobj" Tom Tromey
2014-04-29 16:10 ` Eli Zaretskii
@ 2014-04-29 17:58 ` Joel Brobecker
2014-04-30 13:18 ` Andrew Burgess
2014-05-08 14:37 ` Tom Tromey
3 siblings, 0 replies; 6+ messages in thread
From: Joel Brobecker @ 2014-04-29 17:58 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
> I chose not to install deprecated aliases, since this is only a debug
> setting; but if someone feels strongly about it I will add them.
FWIW, that seems fine to me.
> 2014-04-29 Tom Tromey <tromey@redhat.com>
>
> * varobj.c (_initialize_varobj): Rename to "set debug varobj" and
> "show debug varobj".
>
> 2014-04-29 Tom Tromey <tromey@redhat.com>
>
> * gdb.texinfo (Debugging Output): Rename to "set debug varobj" and
> "show debug varobj".
Thanks for doing that, Tom!
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rename "set debugvarobj" to "set debug varobj"
2014-04-29 15:36 [PATCH] rename "set debugvarobj" to "set debug varobj" Tom Tromey
2014-04-29 16:10 ` Eli Zaretskii
2014-04-29 17:58 ` Joel Brobecker
@ 2014-04-30 13:18 ` Andrew Burgess
2014-05-08 14:35 ` Tom Tromey
2014-05-08 14:37 ` Tom Tromey
3 siblings, 1 reply; 6+ messages in thread
From: Andrew Burgess @ 2014-04-30 13:18 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
On 29/04/2014 4:36 PM, Tom Tromey wrote:
> +++ b/gdb/varobj.c
> @@ -2795,17 +2795,18 @@ void
> _initialize_varobj (void)
> {
> int sizeof_table = sizeof (struct vlist *) * VAROBJ_TABLE_SIZE;
> + struct cmd_list_element *c;
I don't think this extra line is needed.
Cheers,
Andrew
> varobj_table = xmalloc (sizeof_table);
> memset (varobj_table, 0, sizeof_table);
>
> - add_setshow_zuinteger_cmd ("debugvarobj", class_maintenance,
> + add_setshow_zuinteger_cmd ("varobj", class_maintenance,
> &varobjdebug,
> _("Set varobj debugging."),
> _("Show varobj debugging."),
> _("When non-zero, varobj debugging is enabled."),
> NULL, show_varobjdebug,
> - &setlist, &showlist);
> + &setdebuglist, &showdebuglist);
> }
>
> /* Invalidate varobj VAR if it is tied to locals and re-create it if it is
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rename "set debugvarobj" to "set debug varobj"
2014-04-30 13:18 ` Andrew Burgess
@ 2014-05-08 14:35 ` Tom Tromey
0 siblings, 0 replies; 6+ messages in thread
From: Tom Tromey @ 2014-05-08 14:35 UTC (permalink / raw)
To: Andrew Burgess; +Cc: gdb-patches
>> + struct cmd_list_element *c;
Andrew> I don't think this extra line is needed.
Thanks. I was considering adding the deprecated aliases and then
decided against it, but forgot to undo what I did.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rename "set debugvarobj" to "set debug varobj"
2014-04-29 15:36 [PATCH] rename "set debugvarobj" to "set debug varobj" Tom Tromey
` (2 preceding siblings ...)
2014-04-30 13:18 ` Andrew Burgess
@ 2014-05-08 14:37 ` Tom Tromey
3 siblings, 0 replies; 6+ messages in thread
From: Tom Tromey @ 2014-05-08 14:37 UTC (permalink / raw)
To: gdb-patches
Tom> 2014-04-29 Tom Tromey <tromey@redhat.com>
Tom> * varobj.c (_initialize_varobj): Rename to "set debug varobj" and
Tom> "show debug varobj".
Tom> 2014-04-29 Tom Tromey <tromey@redhat.com>
Tom> * gdb.texinfo (Debugging Output): Rename to "set debug varobj" and
Tom> "show debug varobj".
I'm checking this in with the extraneous line removed.
Final patch appended.
Tom
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 09095f1..1b3599c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2014-04-29 Tom Tromey <tromey@redhat.com>
+
+ * varobj.c (_initialize_varobj): Rename to "set debug varobj" and
+ "show debug varobj".
+
2014-05-07 Kyle McMartin <kyle@redhat.com>
Pushed by Joel Brobecker <brobecker@adacore.com>.
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 1e60575..1dee68a 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,8 @@
+2014-04-29 Tom Tromey <tromey@redhat.com>
+
+ * gdb.texinfo (Debugging Output): Rename to "set debug varobj" and
+ "show debug varobj".
+
2014-05-01 David Taylor <dtaylor@emc.com>
* gdb.texinfo (compare-sections): Document the new -r (read-only)
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 7f7650d..2aff5e5 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -22926,11 +22926,11 @@ message.
@item show debug timestamp
Displays the current state of displaying timestamps with @value{GDBN}
debugging info.
-@item set debugvarobj
+@item set debug varobj
@cindex variable object debugging info
Turns on or off display of @value{GDBN} variable object debugging
info. The default is off.
-@item show debugvarobj
+@item show debug varobj
Displays the current state of displaying @value{GDBN} variable object
debugging info.
@item set debug xml
diff --git a/gdb/varobj.c b/gdb/varobj.c
index 10ef5b7..8016368 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -2799,13 +2799,13 @@ _initialize_varobj (void)
varobj_table = xmalloc (sizeof_table);
memset (varobj_table, 0, sizeof_table);
- add_setshow_zuinteger_cmd ("debugvarobj", class_maintenance,
+ add_setshow_zuinteger_cmd ("varobj", class_maintenance,
&varobjdebug,
_("Set varobj debugging."),
_("Show varobj debugging."),
_("When non-zero, varobj debugging is enabled."),
NULL, show_varobjdebug,
- &setlist, &showlist);
+ &setdebuglist, &showdebuglist);
}
/* Invalidate varobj VAR if it is tied to locals and re-create it if it is
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-08 14:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-29 15:36 [PATCH] rename "set debugvarobj" to "set debug varobj" Tom Tromey
2014-04-29 16:10 ` Eli Zaretskii
2014-04-29 17:58 ` Joel Brobecker
2014-04-30 13:18 ` Andrew Burgess
2014-05-08 14:35 ` Tom Tromey
2014-05-08 14:37 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).