From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25192 invoked by alias); 19 May 2014 14:23:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25165 invoked by uid 89); 19 May 2014 14:23:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 19 May 2014 14:23:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D335C116174; Mon, 19 May 2014 10:23:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iaZM-dLcvoIu; Mon, 19 May 2014 10:23:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AADB611616B; Mon, 19 May 2014 10:23:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id AAD1843EBF; Mon, 19 May 2014 07:23:24 -0700 (PDT) Date: Mon, 19 May 2014 14:23:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: "Maciej W. Rozycki" , gdb-patches@sourceware.org Subject: Re: [PATCH] GDB/testsuite: Bump up `match_max' Message-ID: <20140519142324.GB22822@adacore.com> References: <87bnutzwbj.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bnutzwbj.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00347.txt.bz2 > I wonder whether you timed the test suite? > The expect man page says: > > This may be changed with the function match_max. (Note that excessively > large values can slow down the pattern matcher.) > > If it is notably slower then it would be better to rewrite the macro > tests to avoid this need. Funny you would say that! I was reviewing the patch, and decided to do exactly that. Ran into trouble (fresh install), but almost there... -- Joel