public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c
Date: Thu, 22 May 2014 12:49:00 -0000	[thread overview]
Message-ID: <20140522124927.GR22822@adacore.com> (raw)
In-Reply-To: <537DBDF3.1080907@arm.com>

> 	A recent change to glibc removed asm/ptrace.h from user.h for
> AArch64. This meant that cross-native builds of gdb using trunk
> glibc broke because aarch64-linux-nat.c because user_hwdebug_state
> couldn't be found.
> 
> Fixed by including asm/ptrace.h like other ports.

Thanks for the explanation. Can you make sure you include that
in the revision history of your commit?

> 2014-05-22  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
> 
>        * aarch64-linux-nat.c (asm/ptrace.h): Include.
> 

OK to push.  Thank you.


> commit 53278fc086b53264d75ec9cb2a4929565276100a
> Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
> Date:   Thu May 22 09:41:41 2014 +0100
> 
>     Include asm/ptrace.h for recent glibc changes.
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 6f5c9c2..95df3e1 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,9 @@
>  2014-05-22  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
>  
> +	* aarch64-linux-nat.c (asm/ptrace.h): Include.
> +
> +2014-05-22  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
> +
>  	* MAINTAINERS (Write After Approval): Move self back from
>  	Paper trail.
>  
> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index 28ad38b..877e702 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -33,6 +33,7 @@
>  
>  #include <sys/ptrace.h>
>  #include <sys/utsname.h>
> +#include <asm/ptrace.h>
>  
>  #include "gregset.h"
>  


-- 
Joel

  reply	other threads:[~2014-05-22 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22  9:07 Ramana Radhakrishnan
2014-05-22 12:49 ` Joel Brobecker [this message]
2014-05-22 15:43   ` Ramana Radhakrishnan
2014-05-23  8:04   ` Ramana Radhakrishnan
2014-05-23 12:17     ` Richard Earnshaw
2014-05-23 12:45       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522124927.GR22822@adacore.com \
    --to=brobecker@adacore.com \
    --cc=Marcus.Shawcroft@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ramana.radhakrishnan@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).