From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13937 invoked by alias); 22 May 2014 12:49:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13927 invoked by uid 89); 22 May 2014 12:49:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 22 May 2014 12:49:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F39E81161A0; Thu, 22 May 2014 08:49:26 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5u+p2608ZWBC; Thu, 22 May 2014 08:49:26 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C14AE116131; Thu, 22 May 2014 08:49:26 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0B903436C4; Thu, 22 May 2014 05:49:27 -0700 (PDT) Date: Thu, 22 May 2014 12:49:00 -0000 From: Joel Brobecker To: Ramana Radhakrishnan Cc: "gdb-patches@sourceware.org" , Marcus Shawcroft Subject: Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c Message-ID: <20140522124927.GR22822@adacore.com> References: <537DBDF3.1080907@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <537DBDF3.1080907@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00540.txt.bz2 > A recent change to glibc removed asm/ptrace.h from user.h for > AArch64. This meant that cross-native builds of gdb using trunk > glibc broke because aarch64-linux-nat.c because user_hwdebug_state > couldn't be found. > > Fixed by including asm/ptrace.h like other ports. Thanks for the explanation. Can you make sure you include that in the revision history of your commit? > 2014-05-22 Ramana Radhakrishnan > > * aarch64-linux-nat.c (asm/ptrace.h): Include. > OK to push. Thank you. > commit 53278fc086b53264d75ec9cb2a4929565276100a > Author: Ramana Radhakrishnan > Date: Thu May 22 09:41:41 2014 +0100 > > Include asm/ptrace.h for recent glibc changes. > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 6f5c9c2..95df3e1 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,9 @@ > 2014-05-22 Ramana Radhakrishnan > > + * aarch64-linux-nat.c (asm/ptrace.h): Include. > + > +2014-05-22 Ramana Radhakrishnan > + > * MAINTAINERS (Write After Approval): Move self back from > Paper trail. > > diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c > index 28ad38b..877e702 100644 > --- a/gdb/aarch64-linux-nat.c > +++ b/gdb/aarch64-linux-nat.c > @@ -33,6 +33,7 @@ > > #include > #include > +#include > > #include "gregset.h" > -- Joel