Re: [PATCH 0/2 v3] Demangler crash handler

[Gary Benson <gbenson@redhat.com>]

Eli Zaretskii wrote:
> > From: Gary Benson <gbenson@redhat.com>
> > 
> > The news file entries for the commit would be:
> > 
> >   * New options
> >   
> >   maint set catch-demangler-crashes (on|off)
> >   maint show catch-demangler-crashes
> >     Control whether GDB should attempt to catch crashes in the symbol
> >     name demangler.  The default is to attempt to catch crashes.  If
> >     enabled, the first time a crash is caught, a core file is created,
> >     the offending symbol is displayed and the user is presented with
> >     the option to terminate the current session.
> >   
> >   maint set demangler-warning quit (yes|no|ask)
> >     When GDB catches a crash in the symbol name demangler it can offer
> >     the user the opportunity to both quit GDB and create a core file of
> >     the current GDB session.  These options control whether or not to
> >     do either of these.  The default is to create a core file and to ask
> >     the user whether to quit.
> >   
> >   * New commands
> >   
> >   maint demangler-warning
> >     Cause GDB to call the internal function demangler_warning and
> >     hence behave as though an internal error in the demangler has
> >     been detected.
> > 
> > Is this ok to commit?
> 
> The above is too detailed for NEWS.  Do not just copy the text
> from the manual, but instead provide a very short (preferably a
> single-sentence) summary of the new option.

How about these?

  maint set catch-demangler-crashes (on|off)
  maint show catch-demangler-crashes
    Control whether GDB should attempt to catch crashes in the symbol
    name demangler.
  
  maint set demangler-warning quit (yes|no|ask)
    Control whether GDB should exit if it catches a crash in the
    symbol name demangler.

I don't know I could shorten "maint demangler-warning"'s entry any
more without it becoming meaningless.

Thanks,
Gary

-- 
http://gbenson.net/