public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* gdb-7.8 branching status (2014-06-04)
@ 2014-06-04 17:18 Joel Brobecker
  2014-06-04 17:35 ` Pedro Alves
                   ` (3 more replies)
  0 siblings, 4 replies; 23+ messages in thread
From: Joel Brobecker @ 2014-06-04 17:18 UTC (permalink / raw)
  To: gdb-patches

Hello,

Quick update on where we are on branching the gdb-7.8 branch:

  . break-interp.exp/corefile.exp GDB SEGV
    I think Markus sent a patch, and Pedro mostly approved it
    https://www.sourceware.org/ml/gdb-patches/2014-06/msg00148.html

  . PR 16253-induced performance regression
    So far, I only heard from Doug who thinks the best option
    at this point is to temporarily revert the offending patch.
    It would be nice to hear from Keith as well, JIC.

  . Build failure with Python 2.4
    (caused by "Add xmethod support to the Python API")
    https://www.sourceware.org/ml/gdb-patches/2014-06/msg00169.html
    Shouldn't be a problem for the release, since we build without
    -Werror by default, but should not be hard to fix, and would be
    better to have.

  . I just noticed a regression with gdbserver on LynxOS.
    The testing came back just in the nick of time to identify
    the source of the regression:
        commit 802e8e6d8465a0d05803a987ba1bb3237fb2fb70
        [GDBserver] Make Zx/zx packet handling idempotent.
    I will more into it right away.

  . I also noticed what looks like some failures with gdbserver
    on Windows, but I haven't had time to look into this.
    I am hoping it's the same issue was on LynxOS.

I will create a PR(s) as soon as I know more about the issues I detected.

-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 17:18 gdb-7.8 branching status (2014-06-04) Joel Brobecker
@ 2014-06-04 17:35 ` Pedro Alves
  2014-06-04 17:46   ` Joel Brobecker
  2014-06-04 18:20   ` gdb-7.8 branching status (2014-06-04) Joel Brobecker
  2014-06-04 18:41 ` Keith Seitz
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 23+ messages in thread
From: Pedro Alves @ 2014-06-04 17:35 UTC (permalink / raw)
  To: Joel Brobecker, gdb-patches

On 06/04/2014 06:18 PM, Joel Brobecker wrote:

>   . I just noticed a regression with gdbserver on LynxOS.
>     The testing came back just in the nick of time to identify
>     the source of the regression:
>         commit 802e8e6d8465a0d05803a987ba1bb3237fb2fb70
>         [GDBserver] Make Zx/zx packet handling idempotent.
>     I will more into it right away.

Blasphemy!  :-P  Hopefully it'll be a simple issue, like, me
installing the new hooks incorrectly..

I also filed PRs for the gdbserver regressions I had mentioned before.

 [Bug go/17018] New: XFAIL: gdb.go/hello.exp: Starting string check
 https://sourceware.org/PR17018

 [Bug gdb/17019] New: gdb.base/restore.exp failures
 https://sourceware.org/PR17019

 [Bug gdb/17020] New: gdb.base/store.exp failures
 https://sourceware.org/PR17020

 [Bug gdb/17016] New: XFAIL: gdb.threads/dlopen-libpthread.exp: info probes all rtld rtld_map_complete
 https://sourceware.org/PR17016

 [Bug gdb/17015] New: gdb.trace/collection.exp failures
 https://sourceware.org/PR17015

 [Bug gdb/17014] New: gdb.trace/unavailable.exp failures
 https://sourceware.org/PR17014

Likely most of those are system/gcc related though.  I'm diffing
against a gdb.sum from a month ago, and I updated my Fedora in
the mean time...  Still, it's shame that all these are failing
on newer systems.

I'll run the testsuite on my current system against 7.7,
diff the result against mainline, and update the PRs with
what I find out.  If they fail on 7.7 as well, they're not
regressions, so can't be blockers.

-- 
Pedro Alves

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 17:35 ` Pedro Alves
@ 2014-06-04 17:46   ` Joel Brobecker
  2014-06-04 17:54     ` Pedro Alves
  2014-06-04 18:20   ` gdb-7.8 branching status (2014-06-04) Joel Brobecker
  1 sibling, 1 reply; 23+ messages in thread
From: Joel Brobecker @ 2014-06-04 17:46 UTC (permalink / raw)
  To: Pedro Alves; +Cc: gdb-patches

> >   . I just noticed a regression with gdbserver on LynxOS.
> >     The testing came back just in the nick of time to identify
> >     the source of the regression:
> >         commit 802e8e6d8465a0d05803a987ba1bb3237fb2fb70
> >         [GDBserver] Make Zx/zx packet handling idempotent.
> >     I will more into it right away.
> 
> Blasphemy!  :-P  Hopefully it'll be a simple issue, like, me
> installing the new hooks incorrectly..

:-)

It looks like a call to a hook which is NULL (supports_z_point_type),
which probably shoots down my hope of the same issue affecting Windows
as well (there, the hook appears to be non-NULL).

I'm trying to see if I should define it for LynxOS or not, but
then we have the same issue with SPU, I think.

-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 17:46   ` Joel Brobecker
@ 2014-06-04 17:54     ` Pedro Alves
  2014-06-04 17:58       ` Pedro Alves
  0 siblings, 1 reply; 23+ messages in thread
From: Pedro Alves @ 2014-06-04 17:54 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

On 06/04/2014 06:46 PM, Joel Brobecker wrote:

> It looks like a call to a hook which is NULL (supports_z_point_type),
> which probably shoots down my hope of the same issue affecting Windows
> as well (there, the hook appears to be non-NULL).

Ah, I guess you're seeing the crash in mem-break.c:

static int
z_type_supported (char z_type)
{
  return (z_type >= '0' && z_type <= '4'
	  && the_target->supports_z_point_type (z_type));
}

> 
> I'm trying to see if I should define it for LynxOS or not, but
> then we have the same issue with SPU, I think.

The function is a boolean, so assuming false if the
hook is NULL is fine:

  return (z_type >= '0' && z_type <= '4'
+	  && the_target->supports_z_point_type != NULL
	  && the_target->supports_z_point_type (z_type));

-- 
Pedro Alves

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 17:54     ` Pedro Alves
@ 2014-06-04 17:58       ` Pedro Alves
  2014-06-04 18:17         ` [RFA] gdbserver crash if the_target->supports_z_point_type is NULL Joel Brobecker
  0 siblings, 1 reply; 23+ messages in thread
From: Pedro Alves @ 2014-06-04 17:58 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

On 06/04/2014 06:54 PM, Pedro Alves wrote:
> On 06/04/2014 06:46 PM, Joel Brobecker wrote:

>>
>> I'm trying to see if I should define it for LynxOS or not, but
>> then we have the same issue with SPU, I think.
> 
> The function is a boolean, so assuming false if the
> hook is NULL is fine:
> 
>   return (z_type >= '0' && z_type <= '4'
> +	  && the_target->supports_z_point_type != NULL
> 	  && the_target->supports_z_point_type (z_type));
> 

To clarify, neither LynxOS nor SPU install insert_point nor
remove_point hooks either, so the only thing the method
could do if we installed it would be return false.  But since
insert_point and remove_point can be NULL, it feels natural
to allow supports_z_point_type to be NULL too.

-- 
Pedro Alves

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [RFA] gdbserver crash if the_target->supports_z_point_type is NULL
  2014-06-04 17:58       ` Pedro Alves
@ 2014-06-04 18:17         ` Joel Brobecker
  2014-06-04 20:09           ` Pedro Alves
  0 siblings, 1 reply; 23+ messages in thread
From: Joel Brobecker @ 2014-06-04 18:17 UTC (permalink / raw)
  To: gdb-patches; +Cc: Pedro Alves

Hello,

When debugging on LynxOS targets (and probably on SPU targets as well),
inserting a breakpoint and resuming the program's execution causes
GDBserver to crash.

The crash occurs while handling the Z0 packet sent by GDB to insert
our breakpoint, because z_type_supported calls
the_target->supports_z_point_type without checking that it is not NULL
This patch fixes the issue by making z_type_supported return false if
the_target->supports_z_point_type is NULL.

gdb/gdbserver/ChangeLog:

        PR server/17023
        * mem-break.c (z_type_supported): Return zero if
        THE_TARGET->SUPPORTS_Z_POINT_TYPE is NULL.

Tested on ppx-lynx5. I haven't tested on GNU/Linux, but I feel
sufficiently confident since supports_z_point_type is defined there,
and I am eager to take a look at Windows next. But I can do it
if people think it would be best.  OK to push?

Thanks,
-- 
Joel

---
 gdb/gdbserver/mem-break.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/gdbserver/mem-break.c b/gdb/gdbserver/mem-break.c
index 71876f7..2ce3ab2 100644
--- a/gdb/gdbserver/mem-break.c
+++ b/gdb/gdbserver/mem-break.c
@@ -897,6 +897,7 @@ static int
 z_type_supported (char z_type)
 {
   return (z_type >= '0' && z_type <= '4'
+	  && the_target->supports_z_point_type != NULL
 	  && the_target->supports_z_point_type (z_type));
 }
 
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 17:35 ` Pedro Alves
  2014-06-04 17:46   ` Joel Brobecker
@ 2014-06-04 18:20   ` Joel Brobecker
  2014-06-05 13:58     ` Pedro Alves
  1 sibling, 1 reply; 23+ messages in thread
From: Joel Brobecker @ 2014-06-04 18:20 UTC (permalink / raw)
  To: Pedro Alves; +Cc: gdb-patches

> I also filed PRs for the gdbserver regressions I had mentioned before.
> 
>  [Bug go/17018] New: XFAIL: gdb.go/hello.exp: Starting string check
>  https://sourceware.org/PR17018
> 
>  [Bug gdb/17019] New: gdb.base/restore.exp failures
>  https://sourceware.org/PR17019
> 
>  [Bug gdb/17020] New: gdb.base/store.exp failures
>  https://sourceware.org/PR17020
> 
>  [Bug gdb/17016] New: XFAIL: gdb.threads/dlopen-libpthread.exp: info probes all rtld rtld_map_complete
>  https://sourceware.org/PR17016
> 
>  [Bug gdb/17015] New: gdb.trace/collection.exp failures
>  https://sourceware.org/PR17015
> 
>  [Bug gdb/17014] New: gdb.trace/unavailable.exp failures
>  https://sourceware.org/PR17014
> 
> Likely most of those are system/gcc related though.  I'm diffing
> against a gdb.sum from a month ago, and I updated my Fedora in
> the mean time...  Still, it's shame that all these are failing
> on newer systems.
> 
> I'll run the testsuite on my current system against 7.7,
> diff the result against mainline, and update the PRs with
> what I find out.  If they fail on 7.7 as well, they're not
> regressions, so can't be blockers.

Thanks for doing that, Pedro. Let us know when you have the results,
so we know whether we're in the clear or not...

-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 17:18 gdb-7.8 branching status (2014-06-04) Joel Brobecker
  2014-06-04 17:35 ` Pedro Alves
@ 2014-06-04 18:41 ` Keith Seitz
  2014-06-04 22:23   ` Joel Brobecker
  2014-06-04 23:03 ` Joel Brobecker
  2014-06-05 14:40 ` Yao Qi
  3 siblings, 1 reply; 23+ messages in thread
From: Keith Seitz @ 2014-06-04 18:41 UTC (permalink / raw)
  To: Joel Brobecker, gdb-patches

On 06/04/2014 10:18 AM, Joel Brobecker wrote:
>    . PR 16253-induced performance regression
>      So far, I only heard from Doug who thinks the best option
>      at this point is to temporarily revert the offending patch.
>      It would be nice to hear from Keith as well, JIC.

I agree. In fact, I think I mentioned this several days ago on IRC. The 
bug isn't particularly nasty/common/important to block a release. Users 
have had to deal with it for some time, a little while longer won't hurt.

I can provide a patch to revert it from either HEAD or the 7.8 branch. 
Just let me know which you'd prefer. [That is, if Doug hasn't already 
done so or is working on it, but I know he's very, very busy at the moment.]

Keith

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [RFA] gdbserver crash if the_target->supports_z_point_type is NULL
  2014-06-04 18:17         ` [RFA] gdbserver crash if the_target->supports_z_point_type is NULL Joel Brobecker
@ 2014-06-04 20:09           ` Pedro Alves
  2014-06-04 22:21             ` pushed: " Joel Brobecker
  0 siblings, 1 reply; 23+ messages in thread
From: Pedro Alves @ 2014-06-04 20:09 UTC (permalink / raw)
  To: Joel Brobecker, gdb-patches

On 06/04/2014 07:16 PM, Joel Brobecker wrote:
> Hello,
> 
> When debugging on LynxOS targets (and probably on SPU targets as well),
> inserting a breakpoint and resuming the program's execution causes
> GDBserver to crash.
> 
> The crash occurs while handling the Z0 packet sent by GDB to insert
> our breakpoint, because z_type_supported calls
> the_target->supports_z_point_type without checking that it is not NULL
> This patch fixes the issue by making z_type_supported return false if
> the_target->supports_z_point_type is NULL.
> 
> gdb/gdbserver/ChangeLog:
> 
>         PR server/17023
>         * mem-break.c (z_type_supported): Return zero if
>         THE_TARGET->SUPPORTS_Z_POINT_TYPE is NULL.
> 
> Tested on ppx-lynx5. I haven't tested on GNU/Linux, but I feel
> sufficiently confident since supports_z_point_type is defined there,
> and I am eager to take a look at Windows next. But I can do it
> if people think it would be best.  OK to push?

OK.

-- 
Pedro Alves

^ permalink raw reply	[flat|nested] 23+ messages in thread

* pushed: [RFA] gdbserver crash if the_target->supports_z_point_type is NULL
  2014-06-04 20:09           ` Pedro Alves
@ 2014-06-04 22:21             ` Joel Brobecker
  0 siblings, 0 replies; 23+ messages in thread
From: Joel Brobecker @ 2014-06-04 22:21 UTC (permalink / raw)
  To: gdb-patches

> > gdb/gdbserver/ChangeLog:
> > 
> >         PR server/17023
> >         * mem-break.c (z_type_supported): Return zero if
> >         THE_TARGET->SUPPORTS_Z_POINT_TYPE is NULL.
> 
> OK.

Thanks, Pedro. Patch has been pushed.

-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 18:41 ` Keith Seitz
@ 2014-06-04 22:23   ` Joel Brobecker
  2014-06-05 17:26     ` Doug Evans
  0 siblings, 1 reply; 23+ messages in thread
From: Joel Brobecker @ 2014-06-04 22:23 UTC (permalink / raw)
  To: Keith Seitz; +Cc: gdb-patches

> >   . PR 16253-induced performance regression
> >     So far, I only heard from Doug who thinks the best option
> >     at this point is to temporarily revert the offending patch.
> >     It would be nice to hear from Keith as well, JIC.
> 
> I agree. In fact, I think I mentioned this several days ago on IRC.
> The bug isn't particularly nasty/common/important to block a
> release. Users have had to deal with it for some time, a little
> while longer won't hurt.
> 
> I can provide a patch to revert it from either HEAD or the 7.8
> branch. Just let me know which you'd prefer. [That is, if Doug
> hasn't already done so or is working on it, but I know he's very,
> very busy at the moment.]

Thanks, Keith. Doug was only suggesting the revert, so did not offer
to do the revert. Would you mind doing it?

Thanks again,
-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 17:18 gdb-7.8 branching status (2014-06-04) Joel Brobecker
  2014-06-04 17:35 ` Pedro Alves
  2014-06-04 18:41 ` Keith Seitz
@ 2014-06-04 23:03 ` Joel Brobecker
  2014-06-05 21:03   ` Joel Brobecker
  2014-06-05 21:47   ` Joel Brobecker
  2014-06-05 14:40 ` Yao Qi
  3 siblings, 2 replies; 23+ messages in thread
From: Joel Brobecker @ 2014-06-04 23:03 UTC (permalink / raw)
  To: gdb-patches

>   . I also noticed what looks like some failures with gdbserver
>     on Windows, but I haven't had time to look into this.
>     I am hoping it's the same issue was on LynxOS.

I can now say with relative certainty that it isn't the same issue.
It looks related to the fact that target-async is enabled by default.
I'm still gathering evidence, but the the reproducer is a little racy;
it doesn't always fail, and doesn't always fail at the same point :-(.

Sadly, I also noticed that the "maint set target-async" command is
missing on Windows hosts :-(. So that made testing my theory a little
more difficult, and added yet more work before we can cut the 7.8
branch. But in any case, manually setting target_async_permitted
and target_async_permitted_1 (I am paranoid) to 0 allowed me to
pass my test 20 times in a row, as opposed to having it fail roughly
12-15 times.

I will create PRs and investigate further tomorrow.

-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 18:20   ` gdb-7.8 branching status (2014-06-04) Joel Brobecker
@ 2014-06-05 13:58     ` Pedro Alves
  2014-06-05 14:15       ` Keith Seitz
  2014-06-05 21:49       ` Joel Brobecker
  0 siblings, 2 replies; 23+ messages in thread
From: Pedro Alves @ 2014-06-05 13:58 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

On 06/04/2014 07:20 PM, Joel Brobecker wrote:
>> I also filed PRs for the gdbserver regressions I had mentioned before.
>>
>>  [Bug go/17018] New: XFAIL: gdb.go/hello.exp: Starting string check
>>  https://sourceware.org/PR17018
>>
>>  [Bug gdb/17019] New: gdb.base/restore.exp failures
>>  https://sourceware.org/PR17019
>>
>>  [Bug gdb/17020] New: gdb.base/store.exp failures
>>  https://sourceware.org/PR17020
>>
>>  [Bug gdb/17016] New: XFAIL: gdb.threads/dlopen-libpthread.exp: info probes all rtld rtld_map_complete
>>  https://sourceware.org/PR17016
>>
>>  [Bug gdb/17015] New: gdb.trace/collection.exp failures
>>  https://sourceware.org/PR17015
>>
>>  [Bug gdb/17014] New: gdb.trace/unavailable.exp failures
>>  https://sourceware.org/PR17014
>>
>> Likely most of those are system/gcc related though.  I'm diffing
>> against a gdb.sum from a month ago, and I updated my Fedora in
>> the mean time...  Still, it's shame that all these are failing
>> on newer systems.
>>
>> I'll run the testsuite on my current system against 7.7,
>> diff the result against mainline, and update the PRs with
>> what I find out.  If they fail on 7.7 as well, they're not
>> regressions, so can't be blockers.
> 
> Thanks for doing that, Pedro. Let us know when you have the results,
> so we know whether we're in the clear or not...

I've done this now.  I had to rerun all testing in non-parallel mode
to get good diffs...

The "good" news, I get all those FAILs with 7.7 too, so not
regressions.

Apart from the break-interp-exp crashes Markus has a fix for, and
a few PASS -> XFAIL that are marked as GCC bugs, I saw this
with both native and gdbserver:

 -PASS: gdb.cp/koenig.exp: p entry (c)
 +FAIL: gdb.cp/koenig.exp: p entry (c)

This is:

 Regression for gdb.cp/koenig.exp: p entry (c) [Re: [RFA] Fix c++/16253 (tag/variable name collision)]
 https://sourceware.org/ml/gdb-patches/2014-04/msg00374.html

I don't know the current status of that one.  Keith?

and this one on native:

-PASS: gdb.base/pie-execl.exp: continue
-PASS: gdb.base/pie-execl.exp: pie_execl_marker address second
-PASS: gdb.base/pie-execl.exp: pie_execl_marker address has changed
+ERROR: Process no longer exists
+UNRESOLVED: gdb.base/pie-execl.exp: continue

I looked at the backtrace and it's the same as with the
break-interp.exp crashes, so it'll likely be fixed with
Markus' patch.

-- 
Pedro Alves

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-05 13:58     ` Pedro Alves
@ 2014-06-05 14:15       ` Keith Seitz
  2014-06-05 14:39         ` Keith Seitz
  2014-06-05 21:49       ` Joel Brobecker
  1 sibling, 1 reply; 23+ messages in thread
From: Keith Seitz @ 2014-06-05 14:15 UTC (permalink / raw)
  To: Pedro Alves, Joel Brobecker; +Cc: gdb-patches

On 06/05/2014 06:58 AM, Pedro Alves wrote:
> Apart from the break-interp-exp crashes Markus has a fix for, and
> a few PASS -> XFAIL that are marked as GCC bugs, I saw this
> with both native and gdbserver:
>
>   -PASS: gdb.cp/koenig.exp: p entry (c)
>   +FAIL: gdb.cp/koenig.exp: p entry (c)
>
> This is:
>
>   Regression for gdb.cp/koenig.exp: p entry (c) [Re: [RFA] Fix c++/16253 (tag/variable name collision)]
>   https://sourceware.org/ml/gdb-patches/2014-04/msg00374.html
>
> I don't know the current status of that one.  Keith?

I'm working on that one. It's your call, but I hesitate to block a 
release on this. The failure mode is induced by having glibc debuginfo, 
which exports a symbol of the same name ("entry"). The actual feature 
being tested still works, though.

Keith

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-05 14:15       ` Keith Seitz
@ 2014-06-05 14:39         ` Keith Seitz
  0 siblings, 0 replies; 23+ messages in thread
From: Keith Seitz @ 2014-06-05 14:39 UTC (permalink / raw)
  To: Pedro Alves, Joel Brobecker; +Cc: gdb-patches

On 06/05/2014 07:14 AM, Keith Seitz wrote:
> On 06/05/2014 06:58 AM, Pedro Alves wrote:
>> Apart from the break-interp-exp crashes Markus has a fix for, and
>> a few PASS -> XFAIL that are marked as GCC bugs, I saw this
>> with both native and gdbserver:
>>
>>   -PASS: gdb.cp/koenig.exp: p entry (c)
>>   +FAIL: gdb.cp/koenig.exp: p entry (c)
>>
>> This is:
>>
>>   Regression for gdb.cp/koenig.exp: p entry (c) [Re: [RFA] Fix
>> c++/16253 (tag/variable name collision)]
>>   https://sourceware.org/ml/gdb-patches/2014-04/msg00374.html
>>
>> I don't know the current status of that one.  Keith?
>
> I'm working on that one. It's your call, but I hesitate to block a
> release on this. The failure mode is induced by having glibc debuginfo,
> which exports a symbol of the same name ("entry"). The actual feature
> being tested still works, though.

I forgot to mention. Since we are reverting the patch for 16253, this 
regression should go away, too.

https://sourceware.org/ml/gdb-patches/2014-04/msg00374.html

Keith

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 17:18 gdb-7.8 branching status (2014-06-04) Joel Brobecker
                   ` (2 preceding siblings ...)
  2014-06-04 23:03 ` Joel Brobecker
@ 2014-06-05 14:40 ` Yao Qi
  2014-06-05 16:07   ` Pedro Alves
  2014-06-05 21:50   ` Joel Brobecker
  3 siblings, 2 replies; 23+ messages in thread
From: Yao Qi @ 2014-06-05 14:40 UTC (permalink / raw)
  To: Joel Brobecker, gdb-patches

On 06/05/2014 01:18 AM, Joel Brobecker wrote:
> Quick update on where we are on branching the gdb-7.8 branch:

I tested gdb head on both arm-none-eabi and arm-none-linux-gnueabi
yesterday.  Except gdb.cp/koenig.exp fail, there is no regression.
However, there are some new fails (compared with 7.7.1), but none of
them are blockers, IMO.

New FAIL: default/gdb.sum:gdb.base/hbreak-unmapped.exp: hbreak *0
New FAIL: default/gdb.sum:gdb.base/hbreak-unmapped.exp: info break shows
hw breakpoint

bare metal target isn't consider in this case, and I've proposed here
https://sourceware.org/ml/gdb-patches/2014-06/msg00074.html

FAIL: gdb.base/async.exp: finish&
FAIL: gdb.base/async.exp: nexti&
FAIL: gdb.threads/sigstep-threads.exp: continue
FAIL: gdb.threads/sigstep-threads.exp: step 2
FAIL: gdb.stabs/gdb11479.exp: sizeof (*e) in test forced_stabs
FAIL: gdb.stabs/gdb11479.exp: sizeof (*e) in test2 forced_stabs
FAIL: gdb.base/jit.exp: PIE: one_jit_test-1: continue to breakpoint:
break here 2 (the program exited)

I'll take a look.

-- 
Yao (齐尧)

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-05 14:40 ` Yao Qi
@ 2014-06-05 16:07   ` Pedro Alves
  2014-06-05 21:50   ` Joel Brobecker
  1 sibling, 0 replies; 23+ messages in thread
From: Pedro Alves @ 2014-06-05 16:07 UTC (permalink / raw)
  To: Yao Qi, Joel Brobecker, gdb-patches

On 06/05/2014 03:38 PM, Yao Qi wrote:
> On 06/05/2014 01:18 AM, Joel Brobecker wrote:
>> Quick update on where we are on branching the gdb-7.8 branch:
> 
> I tested gdb head on both arm-none-eabi and arm-none-linux-gnueabi
> yesterday.  Except gdb.cp/koenig.exp fail, there is no regression.
> However, there are some new fails (compared with 7.7.1), but none of
> them are blockers, IMO.
> 
> New FAIL: default/gdb.sum:gdb.base/hbreak-unmapped.exp: hbreak *0
> New FAIL: default/gdb.sum:gdb.base/hbreak-unmapped.exp: info break shows
> hw breakpoint
> 
> bare metal target isn't consider in this case, and I've proposed here
> https://sourceware.org/ml/gdb-patches/2014-06/msg00074.html

TBC, this is just a test issue, not a GDB bug.  I've followed up now.

> 
> FAIL: gdb.base/async.exp: finish&
> FAIL: gdb.base/async.exp: nexti&
> FAIL: gdb.threads/sigstep-threads.exp: continue
> FAIL: gdb.threads/sigstep-threads.exp: step 2
> FAIL: gdb.stabs/gdb11479.exp: sizeof (*e) in test forced_stabs
> FAIL: gdb.stabs/gdb11479.exp: sizeof (*e) in test2 forced_stabs
> FAIL: gdb.base/jit.exp: PIE: one_jit_test-1: continue to breakpoint:
> break here 2 (the program exited)

None of these ring a bell to me atm.

> I'll take a look.

Thanks.

-- 
Pedro Alves

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 22:23   ` Joel Brobecker
@ 2014-06-05 17:26     ` Doug Evans
  0 siblings, 0 replies; 23+ messages in thread
From: Doug Evans @ 2014-06-05 17:26 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: Keith Seitz, gdb-patches

On Wed, Jun 4, 2014 at 3:23 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> >   . PR 16253-induced performance regression
>> >     So far, I only heard from Doug who thinks the best option
>> >     at this point is to temporarily revert the offending patch.
>> >     It would be nice to hear from Keith as well, JIC.
>>
>> I agree. In fact, I think I mentioned this several days ago on IRC.
>> The bug isn't particularly nasty/common/important to block a
>> release. Users have had to deal with it for some time, a little
>> while longer won't hurt.
>>
>> I can provide a patch to revert it from either HEAD or the 7.8
>> branch. Just let me know which you'd prefer. [That is, if Doug
>> hasn't already done so or is working on it, but I know he's very,
>> very busy at the moment.]
>
> Thanks, Keith. Doug was only suggesting the revert, so did not offer
> to do the revert. Would you mind doing it?

That'd be awesome.  Thanks!

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 23:03 ` Joel Brobecker
@ 2014-06-05 21:03   ` Joel Brobecker
  2014-06-06 16:30     ` Pedro Alves
  2014-06-05 21:47   ` Joel Brobecker
  1 sibling, 1 reply; 23+ messages in thread
From: Joel Brobecker @ 2014-06-05 21:03 UTC (permalink / raw)
  To: gdb-patches

> >   . I also noticed what looks like some failures with gdbserver
> >     on Windows, but I haven't had time to look into this.
> >     I am hoping it's the same issue was on LynxOS.
> 
> I can now say with relative certainty that it isn't the same issue.
> It looks related to the fact that target-async is enabled by default.
> I'm still gathering evidence, but the the reproducer is a little racy;
> it doesn't always fail, and doesn't always fail at the same point :-(.
> 
> Sadly, I also noticed that the "maint set target-async" command is
> missing on Windows hosts :-(. So that made testing my theory a little
> more difficult, and added yet more work before we can cut the 7.8
> branch. But in any case, manually setting target_async_permitted
> and target_async_permitted_1 (I am paranoid) to 0 allowed me to
> pass my test 20 times in a row, as opposed to having it fail roughly
> 12-15 times.

Hmmmpf, really elusive one to track down as the problem becomes more
and more elusive as you add traces. It looks like communication issue,
although I don't have all the details yet. I created a PR:

    GDB+GDBserver hangs on Windows waiting for stop event since target-async
    on by default
    https://sourceware.org/bugzilla/show_bug.cgi?id=17028

I mentioned target-async in the subject since this seems to be
the trigger that allowed the problem to show up, but so far,
I don't see why this would make a difference.

-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-04 23:03 ` Joel Brobecker
  2014-06-05 21:03   ` Joel Brobecker
@ 2014-06-05 21:47   ` Joel Brobecker
  1 sibling, 0 replies; 23+ messages in thread
From: Joel Brobecker @ 2014-06-05 21:47 UTC (permalink / raw)
  To: gdb-patches

> Sadly, I also noticed that the "maint set target-async" command is
> missing on Windows hosts :-(. So that made testing my theory a little
> more difficult, and added yet more work before we can cut the 7.8
> branch.

FTR: I think I was using a version that was too old, and so this command
was probably not implemented yet. When I tried investigating this issue,
the command was there....

-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-05 13:58     ` Pedro Alves
  2014-06-05 14:15       ` Keith Seitz
@ 2014-06-05 21:49       ` Joel Brobecker
  1 sibling, 0 replies; 23+ messages in thread
From: Joel Brobecker @ 2014-06-05 21:49 UTC (permalink / raw)
  To: Pedro Alves; +Cc: gdb-patches

Thanks again for the update, Pedro.

So we only have one new potential issue:

> This is:
> 
>  Regression for gdb.cp/koenig.exp: p entry (c) [Re: [RFA] Fix c++/16253 (tag/variable name collision)]
>  https://sourceware.org/ml/gdb-patches/2014-04/msg00374.html
> 
> I don't know the current status of that one.  Keith?

-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-05 14:40 ` Yao Qi
  2014-06-05 16:07   ` Pedro Alves
@ 2014-06-05 21:50   ` Joel Brobecker
  1 sibling, 0 replies; 23+ messages in thread
From: Joel Brobecker @ 2014-06-05 21:50 UTC (permalink / raw)
  To: Yao Qi; +Cc: gdb-patches

> I tested gdb head on both arm-none-eabi and arm-none-linux-gnueabi
> yesterday.  Except gdb.cp/koenig.exp fail, there is no regression.
> However, there are some new fails (compared with 7.7.1), but none of
> them are blockers, IMO.
> 
> New FAIL: default/gdb.sum:gdb.base/hbreak-unmapped.exp: hbreak *0
> New FAIL: default/gdb.sum:gdb.base/hbreak-unmapped.exp: info break shows
> hw breakpoint
> 
> bare metal target isn't consider in this case, and I've proposed here
> https://sourceware.org/ml/gdb-patches/2014-06/msg00074.html
> 
> FAIL: gdb.base/async.exp: finish&
> FAIL: gdb.base/async.exp: nexti&
> FAIL: gdb.threads/sigstep-threads.exp: continue
> FAIL: gdb.threads/sigstep-threads.exp: step 2
> FAIL: gdb.stabs/gdb11479.exp: sizeof (*e) in test forced_stabs
> FAIL: gdb.stabs/gdb11479.exp: sizeof (*e) in test2 forced_stabs
> FAIL: gdb.base/jit.exp: PIE: one_jit_test-1: continue to breakpoint:
> break here 2 (the program exited)
> 
> I'll take a look.

Thanks for the update as well.

-- 
Joel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: gdb-7.8 branching status (2014-06-04)
  2014-06-05 21:03   ` Joel Brobecker
@ 2014-06-06 16:30     ` Pedro Alves
  0 siblings, 0 replies; 23+ messages in thread
From: Pedro Alves @ 2014-06-06 16:30 UTC (permalink / raw)
  To: Joel Brobecker, gdb-patches

On 06/05/2014 10:03 PM, Joel Brobecker wrote:

> Hmmmpf, really elusive one to track down as the problem becomes more
> and more elusive as you add traces. It looks like communication issue,
> although I don't have all the details yet. I created a PR:
> 
>     GDB+GDBserver hangs on Windows waiting for stop event since target-async
>     on by default
>     https://sourceware.org/bugzilla/show_bug.cgi?id=17028
> 
> I mentioned target-async in the subject since this seems to be
> the trigger that allowed the problem to show up, but so far,
> I don't see why this would make a difference.

Thanks Joel.  As I said on the PR, I'll try to debug this
too, right after I send out a fix for another issue I'm
addressing atm.

-- 
Pedro Alves

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2014-06-06 16:30 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-04 17:18 gdb-7.8 branching status (2014-06-04) Joel Brobecker
2014-06-04 17:35 ` Pedro Alves
2014-06-04 17:46   ` Joel Brobecker
2014-06-04 17:54     ` Pedro Alves
2014-06-04 17:58       ` Pedro Alves
2014-06-04 18:17         ` [RFA] gdbserver crash if the_target->supports_z_point_type is NULL Joel Brobecker
2014-06-04 20:09           ` Pedro Alves
2014-06-04 22:21             ` pushed: " Joel Brobecker
2014-06-04 18:20   ` gdb-7.8 branching status (2014-06-04) Joel Brobecker
2014-06-05 13:58     ` Pedro Alves
2014-06-05 14:15       ` Keith Seitz
2014-06-05 14:39         ` Keith Seitz
2014-06-05 21:49       ` Joel Brobecker
2014-06-04 18:41 ` Keith Seitz
2014-06-04 22:23   ` Joel Brobecker
2014-06-05 17:26     ` Doug Evans
2014-06-04 23:03 ` Joel Brobecker
2014-06-05 21:03   ` Joel Brobecker
2014-06-06 16:30     ` Pedro Alves
2014-06-05 21:47   ` Joel Brobecker
2014-06-05 14:40 ` Yao Qi
2014-06-05 16:07   ` Pedro Alves
2014-06-05 21:50   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).