From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26677 invoked by alias); 5 Jun 2014 20:06:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26663 invoked by uid 89); 5 Jun 2014 20:06:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jun 2014 20:06:26 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s55K6O6v009392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Jun 2014 16:06:24 -0400 Received: from redacted.bos.redhat.com ([10.18.17.143]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s55K6MOV014780 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 5 Jun 2014 16:06:23 -0400 Date: Thu, 05 Jun 2014 20:06:00 -0000 From: Kyle McMartin To: Andrew Pinski Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH 2/2] aarch64: implement walking over the stack protector Message-ID: <20140605200621.GN15355@redacted.bos.redhat.com> References: <20140603050011.GA15355@redacted.bos.redhat.com> <20140603050314.GC15355@redacted.bos.redhat.com> <20140603145108.GF15355@redacted.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140603145108.GF15355@redacted.bos.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00282.txt.bz2 On Tue, Jun 03, 2014 at 10:51:08AM -0400, Kyle McMartin wrote: > On Mon, Jun 02, 2014 at 10:42:32PM -0700, Andrew Pinski wrote: > > > + adrp x0, __stack_chk_guard > > > + add x0, x0, #:lo12:__stack_chk_guard > > > + ldr x0, [x0] > > > + str x0, [x29, #end-of-stack] > > > > Can you expand this for ILP32? The sequence is the same except to use > > w0 instead of x0. Otherwise I can put it on my todo list to after I > > submit the gdb support for ILP32. > > > > I'll look into it. Thanks Andrew. > Finally got a toolchain built that supports ilp32... looks like the existing code should work for it. The only difference (not sure if it's because of gcc HEAD or what) is using w1 instead of x0 repeated for the ldr/str, which looks to be satisfied by the rt/rt2 tests and size=10 included in the decode_masked_match. I'll try to build a static ilp32 binary to test it meanwhile, but I've had some other issues with gcc HEAD. regards, Kyle