From: Gary Benson <gbenson@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Andrew Burgess <aburgess@broadcom.com>,
Eli Zaretskii <eliz@gnu.org>,
Florian Weimer <fw@deneb.enyo.de>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
Pedro Alves <palves@redhat.com>,
Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH 0/3 v4] Demangler crash handler
Date: Fri, 06 Jun 2014 09:19:00 -0000 [thread overview]
Message-ID: <20140606091855.GC28998@blade.nx> (raw)
In-Reply-To: <CAP9bCMRFjiVf_t4zQ79tfMpvjY+YuD59__pXgEcgSDHFeEzvbg@mail.gmail.com>
Doug Evans wrote:
> On Thu, Jun 5, 2014 at 6:01 AM, Gary Benson <gbenson@redhat.com> wrote:
> > Doug requested that I change the patch to emit warnings for every
> > demangler crash, not just the first.
>
> Umm, that's not what I said, to be precise, and it was more of a
> suggestion for discussion than a request.
Ah, I misunderstood.
>
> > I've not done this, my reason
> > being that subsequent failures could have been caused by the first,
> > by memory corruption or some leftover state: they could be bogus,
> > and could lead to us chasing bugs that don't exist. I prefer this
> > way, but I'm not hung up on it and if it's a blocker for Doug or
> > anyone else I will add the extra warnings.
>
> It's not a blocker to me.
Great :)
Thanks,
Gary
--
http://gbenson.net/
prev parent reply other threads:[~2014-06-06 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 13:01 Gary Benson
2014-06-05 13:02 ` [PATCH 1/3 v4] Add new internal problem for demangler warnings Gary Benson
2014-06-05 13:03 ` [PATCH 2/3 v4] Refactor and expose core-dumping functionality Gary Benson
2014-06-05 16:28 ` Doug Evans
2014-06-06 9:09 ` Gary Benson
2014-06-05 13:04 ` [PATCH 3/3 v4] Demangler crash handler Gary Benson
2014-06-06 18:16 ` Florian Weimer
2014-06-06 19:27 ` Gary Benson
2014-06-06 19:42 ` Florian Weimer
2014-06-06 21:12 ` Andrew Burgess
2014-06-09 9:01 ` Gary Benson
2014-06-09 10:26 ` Andrew Burgess
2014-06-09 11:48 ` Gary Benson
2014-06-05 16:19 ` [PATCH 0/3 " Doug Evans
2014-06-06 9:19 ` Gary Benson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606091855.GC28998@blade.nx \
--to=gbenson@redhat.com \
--cc=aburgess@broadcom.com \
--cc=eliz@gnu.org \
--cc=fw@deneb.enyo.de \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).