public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: tromey@redhat.com
Cc: gbenson@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3 v5] Demangler crash handler
Date: Wed, 11 Jun 2014 21:03:00 -0000	[thread overview]
Message-ID: <201406112103.s5BL3Y1Y025443@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <87y4x3tc05.fsf@fleche.redhat.com> (message from Tom Tromey on	Wed, 11 Jun 2014 14:41:30 -0600)

> From: Tom Tromey <tromey@redhat.com>
> Date: Wed, 11 Jun 2014 14:41:30 -0600
> 
> >>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:
> 
> Gary> This series is an updated version of the demangler crash handler I
> Gary> posted last week.
> 
> Thanks, Gary.
> 
> I re-read the various discussions and my belief is that you've addressed
> all the comments.  I believe Mark has proposed a compromise which you
> implemented, and I believe Stan's objections were contingent on Mark's.
> 
> This patch has been unusually contentious.  So I'd give folks yet
> another opportunity to express their disapprovals; let's say another
> week.
> 
> Disapprovals, I believe, must be accompanied by technical reasons for a
> rejection.  Gary has already addressed most such arguments, so if you
> are responding, please make sure to read the previous threads.

My position still is that this is duct tape being applied because of
extremely bad engineering practices.  Don't expect me to approve the
compromise.  I still think the whole excercise was a tremendous waste
of time.  In fact I feel a little bit blackmailed because Gary kept on
putting work into this diff.  But I'll shut up now.

  reply	other threads:[~2014-06-11 21:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09 15:22 Gary Benson
2014-06-09 15:23 ` [PATCH 1/3 v5] Add new internal problem for demangler warnings Gary Benson
2014-06-09 16:19   ` Eli Zaretskii
2014-06-09 15:24 ` [PATCH 3/3 v5] Demangler crash handler Gary Benson
2014-06-09 16:20   ` Eli Zaretskii
2014-06-09 18:25     ` Gary Benson
2014-07-14  0:31   ` Cygwin build failure following " Pierre Muller
2014-07-14  8:52     ` Corinna Vinschen
2014-07-14 12:10       ` Gary Benson
2014-07-14  8:54     ` Gary Benson
2014-07-14 10:28       ` Andreas Schwab
2014-07-14 12:03         ` Gary Benson
2014-07-14 16:13           ` Tom Tromey
2014-07-14 17:52           ` Pierre Muller
2014-06-09 15:24 ` [PATCH 2/3 v5] Refactor and expose core-dumping functionality Gary Benson
2014-06-11 20:41 ` [PATCH 0/3 v5] Demangler crash handler Tom Tromey
2014-06-11 21:03   ` Mark Kettenis [this message]
2014-06-19  8:23   ` [COMMITTED PATCH " Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201406112103.s5BL3Y1Y025443@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).