From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Keven Boell <keven.boell@intel.com>,
gdb-patches@sourceware.org, sanimir.agovic@intel.com,
Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH 02/23] dwarf: add DW_AT_data_location support
Date: Sat, 14 Jun 2014 13:21:00 -0000 [thread overview]
Message-ID: <20140614132128.GA30958@host2.jankratochvil.net> (raw)
In-Reply-To: <20140610121014.GA6480@adacore.com>
On Tue, 10 Jun 2014 14:10:14 +0200, Joel Brobecker wrote:
> > --- a/gdb/gdbtypes.c
> > +++ b/gdb/gdbtypes.c
> > @@ -1635,8 +1635,12 @@ is_dynamic_type (struct type *type)
> > or the elements it contains have a dynamic contents. */
> > if (is_dynamic_type (TYPE_INDEX_TYPE (type)))
> > return 1;
> > - else
> > - return is_dynamic_type (TYPE_TARGET_TYPE (type));
> > + else if (TYPE_DATA_LOCATION (type) != NULL
> > + && (TYPE_DATA_LOCATION_KIND (type) == PROP_LOCEXPR
> > + || TYPE_DATA_LOCATION_KIND (type) == PROP_LOCLIST))
> > + return 1;
> > + else
> > + return is_dynamic_type (TYPE_TARGET_TYPE (type));
>
> The comment needs to be updated. Your change is also splitting
> the "if bounds or contents is dynamic" logic. Perhaps you could
> simply add the data-location check at the start of the function
> with a command that says: A type which has a data_location which
> [bla bla] is a dynamic type
The indentation is somehow incorrect there.
Jan
next prev parent reply other threads:[~2014-06-14 13:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 5:54 [PATCH 00/23] Fortran dynamic array support Keven Boell
2014-06-04 5:54 ` [PATCH 06/23] vla: reconstruct value to compute bounds of target type Keven Boell
2014-06-04 5:54 ` [PATCH 03/23] vla: introduce allocated/associated flags Keven Boell
2014-06-04 5:54 ` [PATCH 04/23] vla: make dynamic fortran arrays functional Keven Boell
2014-06-16 21:02 ` Jan Kratochvil
2014-06-17 13:53 ` Keven Boell
2014-06-17 17:26 ` Jan Kratochvil
2014-06-04 5:54 ` [PATCH 20/23] test: dynamic string evaluations Keven Boell
2014-06-16 18:41 ` Jan Kratochvil
2014-06-17 13:52 ` Keven Boell
2014-06-04 5:54 ` [PATCH 10/23] vla: get Fortran dynamic strings working Keven Boell
2014-06-04 5:54 ` [PATCH 05/23] vla: make field selection work with vla Keven Boell
2014-06-04 5:54 ` [PATCH 15/23] test: dynamic arrays passed to subroutines Keven Boell
2014-06-04 5:54 ` [PATCH 14/23] test: evaluate dynamic arrays using Fortran primitives Keven Boell
2014-06-04 5:54 ` [PATCH 11/23] vla: add stride support to fortran arrays Keven Boell
2014-06-04 5:54 ` [PATCH 07/23] vla: use value constructor instead of raw-buffer manipulation Keven Boell
2014-06-04 5:54 ` [PATCH 12/23] test: basic tests for dynamic array evaluations in Fortran Keven Boell
2014-06-04 5:54 ` [PATCH 23/23] test: stride support for dynamic arrays Keven Boell
2014-06-04 5:54 ` [PATCH 08/23] vla: get dynamic array corner cases to work Keven Boell
2014-06-04 5:54 ` [PATCH 13/23] test: evaluate Fortran dynamic arrays of types Keven Boell
2014-06-16 20:57 ` Jan Kratochvil
2014-06-04 5:54 ` [PATCH 16/23] test: correct ptype of dynamic arrays in Fortran Keven Boell
2014-06-04 5:55 ` [PATCH 09/23] vla: changed string length semantic Keven Boell
2014-06-04 5:55 ` [PATCH 18/23] test: dynamic arrays passed to functions Keven Boell
2014-06-04 5:55 ` [PATCH 01/23] dwarf: add dwarf3 DW_OP_push_object_address opcode Keven Boell
2014-06-05 20:47 ` Tom Tromey
2014-06-11 12:30 ` Keven Boell
2014-06-10 9:54 ` Joel Brobecker
2014-06-11 12:26 ` Keven Boell
2014-06-11 13:08 ` Joel Brobecker
2014-06-12 7:57 ` Keven Boell
2014-06-12 15:47 ` Joel Brobecker
2014-06-17 13:52 ` Keven Boell
2014-06-21 15:21 ` Joel Brobecker
2014-07-07 15:29 ` Joel Brobecker
2014-06-04 5:55 ` [PATCH 17/23] test: evaluating allocation/association status Keven Boell
2014-06-04 5:55 ` [PATCH 19/23] test: accessing dynamic array history values Keven Boell
2014-06-04 5:55 ` [PATCH 22/23] test: test sizeof for dynamic fortran arrays Keven Boell
2014-06-04 5:55 ` [PATCH 02/23] dwarf: add DW_AT_data_location support Keven Boell
2014-06-10 12:10 ` Joel Brobecker
2014-06-11 12:29 ` Keven Boell
2014-06-14 13:21 ` Jan Kratochvil [this message]
2014-06-04 5:55 ` [PATCH 21/23] test: basic MI test for the dynamic array support Keven Boell
2014-06-04 7:10 ` [PATCH 00/23] Fortran " Eli Zaretskii
2014-06-04 12:50 ` Joel Brobecker
2014-06-14 18:57 ` Jan Kratochvil
2014-06-14 19:39 ` Jan Kratochvil
2014-06-17 13:54 ` Keven Boell
2014-06-17 17:20 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140614132128.GA30958@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keven.boell@intel.com \
--cc=sanimir.agovic@intel.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).