public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Adding bit position to ptype
@ 2014-06-18  3:13 lin zuojian
  2014-06-18 14:31 ` Tom Tromey
  0 siblings, 1 reply; 4+ messages in thread
From: lin zuojian @ 2014-06-18  3:13 UTC (permalink / raw)
  To: gdb-patches

Hi, I am having trouble looking up field offsets when reading disassembled text.
So I add an extra field to ptype:
(gdb) ptype WebCore::FrameLoader
type = class WebCore::FrameLoader {
  private:
    WebCore::Frame *m_frame bitpos: 0;
    WebCore::FrameLoaderClient *m_client bitpos: 32;
    WebCore::PolicyChecker m_policyChecker bitpos: 64;
    WebCore::HistoryController m_history bitpos: 3264;
    WebCore::ResourceLoadNotifier m_notifer bitpos: 3552;
    WebCore::SubframeLoader m_subframeLoader bitpos: 3584;
    WebCore::FrameLoaderStateMachine m_stateMachine bitpos: 3680;
    WebCore::IconController m_icon bitpos: 3712;
...

That helps me a lot to understand what "ldr r0, [r4, #408]" means.
---
 gdb/c-typeprint.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c
index 4edc9ec..9fbbc36 100644
--- a/gdb/c-typeprint.c
+++ b/gdb/c-typeprint.c
@@ -1110,6 +1110,12 @@ c_type_print_base (struct type *type, struct ui_file *stream,
 		    fprintf_filtered (stream, " : %d",
 				      TYPE_FIELD_BITSIZE (type, i));
 		  }
+		else if (!field_is_static (&TYPE_FIELD (type, i)))
+		  {
+		    /* print the bit pos.  */
+		    fprintf_filtered (stream, " bitpos: %d",
+		                      TYPE_FIELD_BITPOS (type, i));
+		  }
 		fprintf_filtered (stream, ";\n");
 	      }
 
-- 
1.9.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-07-01 16:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-18  3:13 [PATCH] Adding bit position to ptype lin zuojian
2014-06-18 14:31 ` Tom Tromey
2014-07-01  9:34   ` lin zuojian
2014-07-01 16:29     ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).