From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31734 invoked by alias); 18 Jun 2014 14:09:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31720 invoked by uid 89); 18 Jun 2014 14:09:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Jun 2014 14:09:56 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5IE9rfv021641 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Jun 2014 10:09:53 -0400 Received: from blade.nx (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5IE9q8k009647; Wed, 18 Jun 2014 10:09:53 -0400 Received: by blade.nx (Postfix, from userid 1000) id 30CB42623FA; Wed, 18 Jun 2014 15:09:52 +0100 (BST) Date: Wed, 18 Jun 2014 14:09:00 -0000 From: Gary Benson To: Pedro Alves Cc: Siva Chandra , gdb-patches Subject: Re: [PATCH 11/15] Rename functions and make nonstatic as necessary Message-ID: <20140618140952.GA28449@blade.nx> References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> <1403014378-4349-12-git-send-email-gbenson@redhat.com> <20140618132832.GA6225@blade.nx> <53A19A53.6030107@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53A19A53.6030107@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00659.txt.bz2 Pedro Alves wrote: > On 06/18/2014 02:28 PM, Gary Benson wrote: > > Siva Chandra wrote: > > > On Tue, Jun 17, 2014 at 7:12 AM, Gary Benson wrote: > > > > This commit renames the functions that are to be shared. > > > > Functions to be shared that were static are made nonstatic. > > > > > > I thinking making the functions nonstatic in this part was > > > not correct. The build currently fails when built with > > > "-Werror=missing-prototypes" as 14/15 has not yet been > > > committed. > > > > My apologies Siva. > > > > Pedro, should I commit the remaining piece now, and work on the > > i386_insert_hw_breakpoint as a separate patch? > > As you've committed the header patch already, I think the issue > is actually already fixed? Ah, ok, I misunderstood. I can stop rushing! I actually wish I hadn't committed the header patch now, the i386_{insert,remove}_hw_breakpoint refactoring you spotted means those functions didn't need exposing at all. I'm working on a patch to revert part of that change: remove the prototypes, make them static again, *and* rename the now static functions them back to their original names. The last point isn't strictly necessary, but I don't like that the refactoring would have renamed some functions it didn't need to. I want to put the old names back so that people familiar with that code don't see more disruption than strictly necessary. I was going to mail it alone (I thought Siva was stuck) but since he's not I'll mail it as part of a three-patch series to complete the refactoring. Thanks, Gary -- http://gbenson.net/