From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: [commit] [patch] Fix --with-system-readline with readline-6.3 patch 5
Date: Fri, 20 Jun 2014 15:46:00 -0000 [thread overview]
Message-ID: <20140620154555.GA18412@host2.jankratochvil.net> (raw)
In-Reply-To: <87d2e3acq4.fsf@fleche.redhat.com>
On Fri, 20 Jun 2014 16:15:47 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> You also have to use system readline-6.3 including its upstream patch:
> Jan> [Bug-readline] Readline-6.3 Official Patch 5
> Jan> http://lists.gnu.org/archive/html/bug-readline/2014-04/msg00018.html
> Jan> Message-ID: <140415125618.AA57598.SM@caleb.ins.cwru.edu>
>
> What's the story with upgrading the in-tree readline?
IMO it should be done, checking the readline/ChangeLog.gdb changes etc.
Personally I find it valid only since readline-6.3 is in Fedora Rawhide now
as Fedora readline maintainer(s) had some issues with it before:
https://bugzilla.redhat.com/show_bug.cgi?id=1071336
> Jan> 2014-06-20 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Jan> Fix --with-system-readline with readline-6.3 patch 5.
> Jan> * tui/tui-io.c (tui_old_rl_getc_function, tui_old_rl_redisplay_function)
> Jan> (tui_old_rl_prep_terminal, tui_old_rl_deprep_terminal): Use rl_*_t
> Jan> types.
>
> Ok.
Checked in:
840ed64d1c1335328e0c4763dc5041d3cdb85c90
Jan
prev parent reply other threads:[~2014-06-20 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 10:50 Jan Kratochvil
2014-06-20 14:15 ` Tom Tromey
2014-06-20 15:46 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620154555.GA18412@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).