From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32347 invoked by alias); 20 Jun 2014 15:46:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32264 invoked by uid 89); 20 Jun 2014 15:46:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Jun 2014 15:46:00 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5KFjx4x017399 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 20 Jun 2014 11:45:59 -0400 Received: from host2.jankratochvil.net (ovpn-116-53.ams2.redhat.com [10.36.116.53]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5KFjuUf027603 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 20 Jun 2014 11:45:58 -0400 Date: Fri, 20 Jun 2014 15:46:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: [commit] [patch] Fix --with-system-readline with readline-6.3 patch 5 Message-ID: <20140620154555.GA18412@host2.jankratochvil.net> References: <20140620105004.GA22236@host2.jankratochvil.net> <87d2e3acq4.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d2e3acq4.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00757.txt.bz2 On Fri, 20 Jun 2014 16:15:47 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> You also have to use system readline-6.3 including its upstream patch: > Jan> [Bug-readline] Readline-6.3 Official Patch 5 > Jan> http://lists.gnu.org/archive/html/bug-readline/2014-04/msg00018.html > Jan> Message-ID: <140415125618.AA57598.SM@caleb.ins.cwru.edu> > > What's the story with upgrading the in-tree readline? IMO it should be done, checking the readline/ChangeLog.gdb changes etc. Personally I find it valid only since readline-6.3 is in Fedora Rawhide now as Fedora readline maintainer(s) had some issues with it before: https://bugzilla.redhat.com/show_bug.cgi?id=1071336 > Jan> 2014-06-20 Jan Kratochvil > > Jan> Fix --with-system-readline with readline-6.3 patch 5. > Jan> * tui/tui-io.c (tui_old_rl_getc_function, tui_old_rl_redisplay_function) > Jan> (tui_old_rl_prep_terminal, tui_old_rl_deprep_terminal): Use rl_*_t > Jan> types. > > Ok. Checked in: 840ed64d1c1335328e0c4763dc5041d3cdb85c90 Jan