From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26242 invoked by alias); 21 Jun 2014 15:21:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26219 invoked by uid 89); 21 Jun 2014 15:21:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 21 Jun 2014 15:21:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3659C1161F6; Sat, 21 Jun 2014 11:21:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vyx8wOwov76p; Sat, 21 Jun 2014 11:21:50 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CE3BB1161F1; Sat, 21 Jun 2014 11:21:49 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0065E40EBB; Sat, 21 Jun 2014 08:21:45 -0700 (PDT) Date: Sat, 21 Jun 2014 15:21:00 -0000 From: Joel Brobecker To: Keven Boell Cc: Keven Boell , gdb-patches@sourceware.org, sanimir.agovic@intel.com Subject: Re: [PATCH 01/23] dwarf: add dwarf3 DW_OP_push_object_address opcode Message-ID: <20140621152145.GA4417@adacore.com> References: <1401861266-6240-1-git-send-email-keven.boell@intel.com> <1401861266-6240-2-git-send-email-keven.boell@intel.com> <20140610095445.GA5259@adacore.com> <53984AE9.7020200@linux.intel.com> <20140611130815.GC4709@adacore.com> <53995BFA.60109@linux.intel.com> <20140612154729.GE4730@adacore.com> <53A0470E.9050206@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53A0470E.9050206@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-06/txt/msg00791.txt.bz2 > So I think having only the address here seems to be ok. [...] > I agree with you that having a struct value instead of an address gives > more flexibility, but for now I think this is not required according to > the DWARF standard. If there is a real-world use-case where a full struct > value object is required instead of having only the address, then this > functionality can be added after this patch series. Thanks for taking the time to try to answer my questions. It all seems reasonable to you, so I agree with your suggestion. I'd like to add a function that resolves a value - that way, the work is going to be centralized at one place. But I would think that I can take care of this independently of your patch series, so you do not need to worry about that for this series. > The patch series has been outdated, due to the introduction of two new > functions by Tom (resolve_dynamic_struct and resolve_dynamic_union). > Shall I therefore submit version 2? Sure. Thanks! -- Joel