From: Gary Benson <gbenson@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dje@google.com, tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 10/14] make dwarf_expr_frame_base_1 public
Date: Tue, 24 Jun 2014 10:18:00 -0000 [thread overview]
Message-ID: <20140624101851.GA9726@blade.nx> (raw)
In-Reply-To: <83ha3bsmgf.fsf@gnu.org>
Eli Zaretskii wrote:
> > Date: Mon, 23 Jun 2014 09:18:15 +0100
> > From: Gary Benson <gbenson@redhat.com>
> > Cc: Tom Tromey <tromey@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
> >
> > > > 2014-06-20 Tom Tromey <tromey@redhat.com>
> > > >
> > > > * dwarf2loc.h (dwarf_expr_frame_base_1): Declare.
> > > > * dwarf2loc.c (dwarf_expr_frame_base_1): Now public.
> > >
> > > [apologies for the repeat ... curse you gmail ...]
> > >
> > > Can you remove the _1?
> > > (renaming it as needed)
> > > I see the non _1 version is also static, so some reasonable renaming
> > > (perhaps of both) should be simple enough.
> >
> > Is there some convention about what "_1" means in a function name?
>
> In most, if not all, cases I saw those are internal subroutines of the
> sans-_1 peers.
Is "_1" acceptable in new code? I have a vague memory of having to
update a patch to rename a new "_1" function I'd created. If it's
not then maybe these should be renamed as people touch them.
In any event, I don't think any non-static function should be called
"_1".
Thanks,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2014-06-24 10:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 15:58 [PATCH v2 00/15] let gdb reuse gcc's C compiler Tom Tromey
2014-06-20 15:58 ` [PATCH v2 03/14] add some missing ops to DWARF assembler Tom Tromey
2014-06-20 15:58 ` [PATCH v2 02/14] add gcc/gdb interface files Tom Tromey
2014-06-20 15:58 ` [PATCH v2 01/14] introduce ui_file_write_for_put Tom Tromey
2014-06-20 15:58 ` [PATCH v2 11/14] export dwarf2_reg_to_regnum_or_error Tom Tromey
2014-06-20 15:58 ` [PATCH v2 09/14] split dwarf2_fetch_cfa_info from dwarf2_compile_expr_to_ax Tom Tromey
2014-06-20 15:58 ` [PATCH v2 04/14] add make_unqualified_type Tom Tromey
2014-06-20 15:58 ` [PATCH v2 14/14] the "compile" command Tom Tromey
2014-06-20 19:17 ` Eli Zaretskii
2014-10-08 17:45 ` Jan Kratochvil
2014-10-08 18:42 ` Eli Zaretskii
2014-10-08 19:42 ` Jan Kratochvil
2014-06-20 16:26 ` [PATCH v2 13/14] add s390_gcc_target_options Tom Tromey
2014-06-20 16:32 ` [PATCH v2 12/14] add linux_infcall_mmap Tom Tromey
2014-06-20 16:32 ` [PATCH v2 07/14] add gnu_triplet_regexp gdbarch method Tom Tromey
2014-06-20 16:32 ` [PATCH v2 05/14] add dummy frame destructor Tom Tromey
2014-06-20 16:33 ` [PATCH v2 10/14] make dwarf_expr_frame_base_1 public Tom Tromey
2014-06-20 20:05 ` Doug Evans
2014-06-23 8:18 ` Gary Benson
2014-06-23 14:57 ` Eli Zaretskii
2014-06-24 10:18 ` Gary Benson [this message]
2014-06-24 13:04 ` Pedro Alves
2014-10-08 16:57 ` Jan Kratochvil
2014-06-20 16:39 ` [PATCH v2 08/14] introduce call_function_by_hand_dummy Tom Tromey
2014-06-20 16:51 ` [PATCH v2 06/14] add infcall_mmap and gcc_target_options gdbarch methods Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624101851.GA9726@blade.nx \
--to=gbenson@redhat.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).