From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Add dprintf and detach test (PR breakpoints/17012)
Date: Mon, 07 Jul 2014 15:06:00 -0000 [thread overview]
Message-ID: <20140707150614.GG6038@adacore.com> (raw)
In-Reply-To: <53B40946.3080102@ericsson.com>
Hello Simon,
> 2014-06-18 Simon Marchi simon.marchi@ericsson.com
>
> PR breakpoints/17012
> gdb.base/dprintf-detach.c: New file.
> gdb.base/dprintf-detach.exp: New file.
Sorry for the delay in answering this.
> diff --git a/gdb/testsuite/gdb.base/dprintf-detach.c b/gdb/testsuite/gdb.base/dprintf-detach.c
> new file mode 100644
> index 0000000..91f49ce
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/dprintf-detach.c
> @@ -0,0 +1,18 @@
> +#include <stdlib.h>
This file needs a copyright notice, please.
> diff --git a/gdb/testsuite/gdb.base/dprintf-detach.exp b/gdb/testsuite/gdb.base/dprintf-detach.exp
> new file mode 100644
> index 0000000..18ba154
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/dprintf-detach.exp
> @@ -0,0 +1,80 @@
> +# Copyright 2003-2014 Free Software Foundation, Inc.
Can you confirm that 2003 is the correct year for the start
of the range?
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>. */
> +
> +# This test checks that inserting a dprintf and detaching does not crash
> +# the program.
> +#
> +# Related bug: https://sourceware.org/bugzilla/show_bug.cgi?id=17012
> +
> +# Only GNU/Linux is known to support (dprintf and detach).
> +if { ! [istarget "*-*-linux*"] } {
> + return 0
> +}
> +
> +# Are we on a target board?
> +if [is_remote target] then {
> + return 0
> +}
> +
> +standard_testfile
> +set escapedbinfile [string_to_regexp ${binfile}]
> +
> +if [prepare_for_testing "failed to prepare for dprintf-detach" \
> + ${testfile} ${srcfile} {debug}] {
> + return -1
> +}
> +
> +# The problem was showing up in non-stop mode, since it enables
> +# "breakpoint always-inserted", so this could also be
> +# "set breakpoint always-inserted on".
> +gdb_test_no_output "set non-stop on"
> +
> +if ![runto_main] {
> + fail "Can't run to main"
> + return -1
> +}
> +
> +# Get PID of test program.
> +set inferior_pid -1
> +set test "get inferior process ID"
> +gdb_test_multiple "call getpid ()" $test {
> + -re ".* = ($decimal).*$gdb_prompt $" {
> + set inferior_pid $expect_out(1,string)
> + pass $test
> + }
> +}
> +
> +# Add a dprintf and detach.
> +gdb_test "dprintf function, \"hello\"" "Dprintf .*" "dprintf insertion"
> +gdb_test "detach" "Detaching from program: .*$escapedbinfile, .*" "detach program"
> +
> +# Exit gdb. Until we do that, the process will exist as a zombie.
Two spaces after the period.
> +gdb_exit
> +
> +# Give some time for the ex-inferior to run and hopefully not crash.
> +sleep 1
> +
> +# Check that the process still exists.
> +set test "detached process should continue to exist"
> +if {[catch {exec kill -0 $inferior_pid}]} {
> + # Process does not exist.
> + fail "$test"
> +} else {
> + # Process exists.
> + pass "$test"
> +}
> +
> +# Clean up.
> +catch {exec kill -9 $inferior_pid}
I am not quite sure about how well how the above would work in practice.
How about restarting GDB, and do an "attach" gdb_test? That way, we
can kill the inferior process from GDB as well. (it's a good thing
you used a 30-times loops as well to make sure the process eventually
terminates on its own as well).
--
Joel
next prev parent reply other threads:[~2014-07-07 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 14:26 Simon Marchi
2014-06-18 14:26 ` [PATCH 2/2] Only leave dprintf inserted if it is marked as persistent " Simon Marchi
2014-07-02 13:29 ` [PATCH 1/2] Add dprintf and detach test " Simon Marchi
2014-07-07 15:06 ` Joel Brobecker [this message]
2014-07-07 17:20 ` Simon Marchi
2014-07-07 20:23 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707150614.GG6038@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).