From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20250 invoked by alias); 7 Jul 2014 15:29:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20217 invoked by uid 89); 7 Jul 2014 15:29:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 07 Jul 2014 15:29:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9EB2511620D; Mon, 7 Jul 2014 11:29:54 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ck9oMpwWB982; Mon, 7 Jul 2014 11:29:54 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 65FFC116201; Mon, 7 Jul 2014 11:29:54 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1DEC740F62; Mon, 7 Jul 2014 08:29:53 -0700 (PDT) Date: Mon, 07 Jul 2014 15:29:00 -0000 From: Joel Brobecker To: Keven Boell Cc: Keven Boell , gdb-patches@sourceware.org, sanimir.agovic@intel.com Subject: Re: [PATCH 01/23] dwarf: add dwarf3 DW_OP_push_object_address opcode Message-ID: <20140707152953.GJ6038@adacore.com> References: <1401861266-6240-1-git-send-email-keven.boell@intel.com> <1401861266-6240-2-git-send-email-keven.boell@intel.com> <20140610095445.GA5259@adacore.com> <53984AE9.7020200@linux.intel.com> <20140611130815.GC4709@adacore.com> <53995BFA.60109@linux.intel.com> <20140612154729.GE4730@adacore.com> <53A0470E.9050206@linux.intel.com> <20140621152145.GA4417@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140621152145.GA4417@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-07/txt/msg00121.txt.bz2 > I'd like to add a function that resolves a value - that way, the work > is going to be centralized at one place. But I would think that I can > take care of this independently of your patch series, so you do not > need to worry about that for this series. FTR, I gave it a try a few weeks ago being going away for a while, and found that it was probably not as straightforward as one thought. Extracting the original value's type and address to create resolved type is pretty straightforward if you assume that the value address is always going to be valid if the type uses dynamic properties. But reconstructing a value from that original value and the new type seems a lot trickier. If the value has a location, is the location to be preserved, for instance? I don't want to create a non-lval value if the original value was an lval. That way, expressions involving operators such as the address operator still work. Thoughts? -- Joel