From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: eliz@gnu.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Re: Regression for GDB global --statistics
Date: Fri, 11 Jul 2014 21:33:00 -0000 [thread overview]
Message-ID: <20140711212537.GA19551@host2.jankratochvil.net> (raw)
In-Reply-To: <21437.45024.997531.453750@ruffy.mtv.corp.google.com>
On Wed, 09 Jul 2014 23:10:56 +0200, Doug Evans wrote:
> --- a/gdb/testsuite/gdb.base/maint.exp
> +++ b/gdb/testsuite/gdb.base/maint.exp
> @@ -130,10 +130,11 @@ gdb_expect {
> # tests here!!
> gdb_test_no_output "maint check-symtabs"
>
> +# Test per-command stats.
> gdb_test_no_output "maint set per-command on"
> -
> -gdb_test "maint set per-command off" \
> +gdb_test "pwd" \
> "Command execution time: \[0-9.\]+ \\(cpu\\), \[0-9.\]+ \\(wall\\)\[\r\n\]+Space used: $decimal \\(\\+$decimal for this command\\)\[\r\n\]+#symtabs: $decimal \\(\\+$decimal\\), #primary symtabs: $decimal \\(\\+$decimal\\), #blocks: $decimal \\(\\+$decimal\\)"
> +gdb_test_no_output "maint set per-command off"
Is it needed to change this behavior? It may break some user scripts working
fine with previous GDB stable releases.
Besides that the startup statistics regression is not tested here but I can
post then a testcase for it.
Thanks,
Jan
next prev parent reply other threads:[~2014-07-11 21:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 23:44 [doc RFA] New commands: mt set per-command on|off Doug Evans
2013-03-17 19:04 ` Eli Zaretskii
[not found] ` <20807.35450.682935.524373@ruffy2.mtv.corp.google.com>
2013-03-20 17:24 ` Eli Zaretskii
2013-03-21 17:54 ` Doug Evans
2013-03-28 23:27 ` doc/ build regression with texinfo-5.1 [Re: [doc RFA] New commands: mt set per-command on|off] Jan Kratochvil
2013-03-29 0:27 ` Eli Zaretskii
2013-03-29 16:50 ` Jan Kratochvil
2013-03-29 16:57 ` Doug Evans
2013-03-29 16:58 ` Jan Kratochvil
2013-03-29 21:50 ` Eli Zaretskii
2014-06-30 17:13 ` Regression for GDB global --statistics " Jan Kratochvil
2014-07-09 21:11 ` [PATCH] Re: Regression for GDB global --statistics Doug Evans
2014-07-10 16:42 ` Pedro Alves
2014-07-12 0:42 ` Doug Evans
2014-07-15 9:43 ` Pedro Alves
2014-07-17 12:02 ` Doug Evans
2014-07-11 21:33 ` Jan Kratochvil [this message]
2014-07-11 22:05 ` Doug Evans
2014-07-12 20:25 ` [testsuite patch] " Jan Kratochvil
[not found] ` <CADPb22SxWYQ-6tK85p2koVQjxrFF0o3OtmEd79R0q-_xWcJ+Mg@mail.gmail.com>
2014-07-17 12:23 ` [testsuite commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711212537.GA19551@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).