From: Gary Benson <gbenson@redhat.com>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: gdb-patches@sourceware.org,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
Andrew Burgess <aburgess@broadcom.com>,
Doug Evans <xdje42@gmail.com>,
Eli Zaretskii <eliz@gnu.org>,
Florian Weimer <fw@deneb.enyo.de>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
Pedro Alves <palves@redhat.com>,
Tom Tromey <tromey@redhat.com>
Subject: Re: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler
Date: Mon, 14 Jul 2014 12:10:00 -0000 [thread overview]
Message-ID: <20140714120257.GB31867@blade.nx> (raw)
In-Reply-To: <20140714083643.GA10872@calimero.vinschen.de>
Corinna Vinschen wrote:
> On Jul 13 18:11, Pierre Muller wrote:
> > A simple patch would probably be to add a separate check
> > #ifdef SA_ONSTACK
> > sa.sa_flags = SA_O?STACK;
> > #endif
>
> Right, Cygwin doesn't support SA_ONSTACK yet. It should be
> possible to add, but there are no immediate plans to do so.
>
> As for the above, wouldn't it be better to add something like
>
> #ifndef SA_ONSTACK
> #define SA_ONSTACK 0
> #endif
>
> to some header?
I'd prefer not to. Having the conditional where the handler
is installed makes it obvious that the alternate stack is not
available on all systems.
Thanks,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2014-07-14 12:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 15:22 [PATCH 0/3 " Gary Benson
2014-06-09 15:23 ` [PATCH 1/3 v5] Add new internal problem for demangler warnings Gary Benson
2014-06-09 16:19 ` Eli Zaretskii
2014-06-09 15:24 ` [PATCH 3/3 v5] Demangler crash handler Gary Benson
2014-06-09 16:20 ` Eli Zaretskii
2014-06-09 18:25 ` Gary Benson
2014-07-14 0:31 ` Cygwin build failure following " Pierre Muller
2014-07-14 8:52 ` Corinna Vinschen
2014-07-14 12:10 ` Gary Benson [this message]
2014-07-14 8:54 ` Gary Benson
2014-07-14 10:28 ` Andreas Schwab
2014-07-14 12:03 ` Gary Benson
2014-07-14 16:13 ` Tom Tromey
2014-07-14 17:52 ` Pierre Muller
2014-06-09 15:24 ` [PATCH 2/3 v5] Refactor and expose core-dumping functionality Gary Benson
2014-06-11 20:41 ` [PATCH 0/3 v5] Demangler crash handler Tom Tromey
2014-06-11 21:03 ` Mark Kettenis
2014-06-19 8:23 ` [COMMITTED PATCH " Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714120257.GB31867@blade.nx \
--to=gbenson@redhat.com \
--cc=aburgess@broadcom.com \
--cc=eliz@gnu.org \
--cc=fw@deneb.enyo.de \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=palves@redhat.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=tromey@redhat.com \
--cc=vinschen@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).