From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4734 invoked by alias); 14 Jul 2014 12:03:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4713 invoked by uid 89); 14 Jul 2014 12:03:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 14 Jul 2014 12:03:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6EC2xuM017241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Jul 2014 08:02:59 -0400 Received: from blade.nx (ovpn-116-93.ams2.redhat.com [10.36.116.93]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6EC2vat029865; Mon, 14 Jul 2014 08:02:58 -0400 Received: by blade.nx (Postfix, from userid 1000) id 39A7A2640C7; Mon, 14 Jul 2014 13:02:57 +0100 (BST) Date: Mon, 14 Jul 2014 12:10:00 -0000 From: Gary Benson To: Corinna Vinschen Cc: gdb-patches@sourceware.org, Pierre Muller , Andrew Burgess , Doug Evans , Eli Zaretskii , Florian Weimer , Mark Kettenis , Pedro Alves , Tom Tromey Subject: Re: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler Message-ID: <20140714120257.GB31867@blade.nx> References: <20140609152229.GA27494@blade.nx> <20140609152434.GD27494@blade.nx> <000901cf9eb5$16841da0$438c58e0$@muller@ics-cnrs.unistra.fr> <20140714083643.GA10872@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140714083643.GA10872@calimero.vinschen.de> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00320.txt.bz2 Corinna Vinschen wrote: > On Jul 13 18:11, Pierre Muller wrote: > > A simple patch would probably be to add a separate check > > #ifdef SA_ONSTACK > > sa.sa_flags = SA_O?STACK; > > #endif > > Right, Cygwin doesn't support SA_ONSTACK yet. It should be > possible to add, but there are no immediate plans to do so. > > As for the above, wouldn't it be better to add something like > > #ifndef SA_ONSTACK > #define SA_ONSTACK 0 > #endif > > to some header? I'd prefer not to. Having the conditional where the handler is installed makes it obvious that the alternate stack is not available on all systems. Thanks, Gary -- http://gbenson.net/