From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 768 invoked by alias); 16 Jul 2014 08:55:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 757 invoked by uid 89); 16 Jul 2014 08:55:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Jul 2014 08:55:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6G8tgDq030655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Jul 2014 04:55:42 -0400 Received: from blade.nx (ovpn-116-88.ams2.redhat.com [10.36.116.88]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6G8tfA9009613; Wed, 16 Jul 2014 04:55:42 -0400 Received: by blade.nx (Postfix, from userid 1000) id 828242640C7; Wed, 16 Jul 2014 09:55:41 +0100 (BST) Date: Wed, 16 Jul 2014 10:23:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 11/15] More target unification Message-ID: <20140716085541.GB22380@blade.nx> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-12-git-send-email-gbenson@redhat.com> <21444.11203.526875.132980@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21444.11203.526875.132980@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00416.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > +/* See target/target.h. */ > > + > > +void > > +target_resume (ptid_t ptid, int step, enum gdb_signal signal) > > +{ > > + struct thread_resume resume_info; > > + > > + resume_info.thread = ptid; > > + resume_info.kind = step ? resume_step : resume_continue; > > + resume_info.sig = GDB_SIGNAL_0; > > + (*the_target->resume) (&resume_info, 1); > > +} > > I'm guessing the ignoring of signal is an oversight, right? Looks that way, I'll fix it. Good catch BTW! Cheers, Gary -- http://gbenson.net/