From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31181 invoked by alias); 9 Sep 2014 15:45:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31171 invoked by uid 89); 9 Sep 2014 15:45:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 09 Sep 2014 15:45:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A5FE811649B; Tue, 9 Sep 2014 11:45:29 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EPNLkuPjDLsE; Tue, 9 Sep 2014 11:45:29 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7715A11649C; Tue, 9 Sep 2014 11:45:29 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2BC71477FF; Tue, 9 Sep 2014 08:45:31 -0700 (PDT) Date: Tue, 09 Sep 2014 15:45:00 -0000 From: Joel Brobecker To: Gabriel Krisman Bertazi Cc: gdb-patches@sourceware.org Subject: Re: [PING] [PATCH] Fix gdb.fortran/array-element.exp failures. Message-ID: <20140909154531.GJ28404@adacore.com> References: <87zjgobth0.fsf@Argo.krisman.be> <8761jbbu6l.fsf@Argo.krisman.be> <87lhrv36pm.fsf@Argo.krisman.be> <87zjf3sqrd.fsf@krisman.be> <87r4048546.fsf_-_@krisman.be> <20140909130901.GG28404@adacore.com> <87d2b4c07h.fsf@anubis.Home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d2b4c07h.fsf@anubis.Home> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00236.txt.bz2 > Sorry I didn't resend the original message with my pings. Here it goes. > > This fixes two FAIL results when running this test file due to a > misplaced "continue" command, which caused the inferior to end execution > prematurely. > > On trunk, we have: > > FAIL: gdb.fortran/array-element.exp: continue to breakpoint once again > (the program exited) > FAIL: gdb.fortran/array-element.exp: print the second element of array a > > === gdb Summary === > > # of expected passes 3 > # of unexpected failures 2 > > And now, we get: > === gdb Summary === > # of expected passes 3 > > Is this ok? The problem is that this does not tell me what was wrong. Just that some tests did not pass. Although your change seems OK at first glance, I'd like to do know what it was that did not match, and why it's OK stop trying to match it now. -- Joel