public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [GCC PR55056] Re: [RFC patch] testsuite: Workaround issues with GCC 4.8.0pre + gdb.trace new KFAIL
Date: Wed, 10 Sep 2014 20:29:00 -0000	[thread overview]
Message-ID: <20140910200657.GA11350@host2.jankratochvil.net> (raw)
In-Reply-To: <21519.28248.577451.227482@ruffy2.mtv.corp.google.com>

On Tue, 09 Sep 2014 23:17:12 +0200, Doug Evans wrote:
> Have you thought of how you might do it differently now?

gcc-4.4.7-4.el6.x86_64 at least for restore.exp produces with line 75:
	gdb_test "info addr l$var"
only patterns:
	Symbol "l\d+" is a variable in $r\d+.

While gcc-4.9.1-7.fc21.x86_64 with the patch of mine we discuss here produces
in half the cases:
	Symbol "l1" is a complex DWARF expression: 0: DW_OP_fbreg -44
And therefore the testcase no longer really tests the GDB feature.

Therefore proposing to make it x86_64 arch specific testcase with
gcc-4.4.7-4.el6.x86_64-precompiled .S file.

For the test I tried only restore.exp now, I will check more the others.

Another possibility would be to make the testcase -Og compatible as GCC
hackers in
	https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55056
say that the variables then should not be <optimized out>.
I have tested that with -Og the testcase currently FAILs already on various
line-matching issues.  But I find the arch-specific .S file safer.


Jan

      reply	other threads:[~2014-09-10 20:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-26 20:27 Jan Kratochvil
2013-01-28 19:57 ` Yao Qi
2013-01-29 18:16   ` Jan Kratochvil
     [not found]     ` <20130202092240.GA24458@host2.jankratochvil.net>
2013-02-03 17:27       ` Jan Kratochvil
2013-06-14 13:39         ` [GCC PR55056] " Thomas Schwinge
2013-06-14 14:24           ` Jan Kratochvil
2014-09-09 21:17             ` Doug Evans
2014-09-10 20:29               ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140910200657.GA11350@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).