From: Joel Brobecker <brobecker@adacore.com>
To: Thomas Schwinge <thomas@codesourcery.com>,
Gary Benson <gbenson@redhat.com>,
bug-hurd@gnu.org, gdb-patches@sourceware.org
Subject: Re: [PATCHv3,Hurd] Add hardware watch support
Date: Mon, 15 Sep 2014 13:50:00 -0000 [thread overview]
Message-ID: <20140915135004.GJ4871@adacore.com> (raw)
In-Reply-To: <20140912211354.GI3202@type.youpi.perso.aquilenet.fr>
> Seeing a submission to gdb getting stuck on missing line breaks got me
> a bit on my nerves. Fortunately it wasn't only about that, but also
> important changes, so I carried on, but having to resubmit only for
> missing spaces or new lines would have been really hard to me, since I
> don't really plan to submit many patches to gdb, and I know I'll
> always make this kind of mistakes since I'm submitting patches to a
> lot of various projects with very differing coding styles.
I understand the fustration, and I certainly would agree if you said
that GDB is very particular with its CS. Aiming for a consistent coding
style is important for long-term maintainability, though, which is why
we almost systematically mention violations we see. If it makes you feel
any better, we make mistakes too, sometimes, and have to re-edit as
a result. One thing I will say, however, is that I often let go of
minor violations, and only mention them if there are other adjustments
I'd like to request in the same area. And I know others can be the same.
So we try not be be overly picky (you may not believe me on that one ;-)!).
As Sergio mentioned, we do not have a script we can use to check
coding-style violations. We would very much like to have one,
but no one really sent anything so far. What I can do to help is
being your CS corrector - just send me your patch privately before
submitting, and I will fix all CS violations for you.
Another important part I can see contributing to the fustration
is review delays. I can see how trivial requests can be extra
fustrating if you feel like your patch is being delayed quite
a bit because each review cycle is very long. You can help with
that by pinging us. The accepted practice is to ping after a week
or two, and every week thereafter.
--
Joel
next prev parent reply other threads:[~2014-09-15 13:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 22:49 Samuel Thibault
2014-09-10 23:23 ` Sergio Durigan Junior
2014-09-12 18:21 ` Samuel Thibault
2014-09-12 19:18 ` Sergio Durigan Junior
2014-09-12 16:51 ` Joel Brobecker
2014-09-12 18:24 ` Samuel Thibault
2014-09-12 17:56 ` Thomas Schwinge
2014-09-12 18:01 ` Samuel Thibault
2014-09-12 20:01 ` Joel Brobecker
2014-09-12 21:24 ` Samuel Thibault
2014-09-12 21:42 ` Sergio Durigan Junior
2014-09-15 13:50 ` Joel Brobecker [this message]
2014-09-12 18:25 ` Samuel Thibault
2014-09-15 22:08 ` Thomas Schwinge
2014-09-15 23:09 ` Samuel Thibault
2014-09-16 9:00 ` Thomas Schwinge
2014-09-16 23:17 ` Samuel Thibault
2014-09-16 23:29 ` Samuel Thibault
2014-09-17 9:02 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915135004.GJ4871@adacore.com \
--to=brobecker@adacore.com \
--cc=bug-hurd@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).