Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()

Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()

[Joel Brobecker]

Hi Chen,

> The related warning under Darwin x86_64:
> 
>   gcc -c -DHAVE_CONFIG_H    -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
>   ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
>     rl_message ("%s", p, 0);
>                 ~~~~     ^
>   1 warning generated.
> 
> 
> readline/ChangeLog.gdb:
> 
> 	* search.c (_rl_nsearch_init): Remove useless parameter '0' for
> 	rl_message().

Because readline is a separate project from binutils/GDB, we prefer
it if you would first submit the patch to the readline project first
(bug-readline@gnu.org, in Cc: of this email), get it accepted there.
Once pushed in the readline project, we can then merge your patch.
Would you mind taking the lead in telling us when the patch is readline?

Thank you!

> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  readline/search.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/readline/search.c b/readline/search.c
> index 04468fc..bf525e6 100644
> --- a/readline/search.c
> +++ b/readline/search.c
> @@ -210,7 +210,7 @@ _rl_nsearch_init (dir, pchar)
>    rl_end = rl_point = 0;
>  
>    p = _rl_make_prompt_for_search (pchar ? pchar : ':');
> -  rl_message ("%s", p, 0);
> +  rl_message ("%s", p);
>    xfree (p);
>  
>    RL_SETSTATE(RL_STATE_NSEARCH);
> -- 
> 1.8.5.2 (Apple Git-48)

-- 
Joel

Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()

[Andreas Schwab]

Joel Brobecker <brobecker@adacore.com> writes:

> Hi Chen,
>
>> The related warning under Darwin x86_64:
>> 
>>   gcc -c -DHAVE_CONFIG_H    -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
>>   ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
>>     rl_message ("%s", p, 0);
>>                 ~~~~     ^
>>   1 warning generated.
>> 
>> 
>> readline/ChangeLog.gdb:
>> 
>> 	* search.c (_rl_nsearch_init): Remove useless parameter '0' for
>> 	rl_message().
>
> Because readline is a separate project from binutils/GDB, we prefer
> it if you would first submit the patch to the readline project first
> (bug-readline@gnu.org, in Cc: of this email), get it accepted there.

This bug was already fixed in bash 4.3.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()

[Jan Kratochvil]

On Mon, 22 Sep 2014 15:03:24 +0200, Joel Brobecker wrote:
> Because readline is a separate project from binutils/GDB, we prefer
> it if you would first submit the patch to the readline project first
> (bug-readline@gnu.org, in Cc: of this email), get it accepted there.
> Once pushed in the readline project, we can then merge your patch.
> Would you mind taking the lead in telling us when the patch is readline?

It already is:
	http://git.savannah.gnu.org/cgit/bash.git/diff/lib/readline/search.c?h=devel&id=d76edd307c1e53bcf497723365dfa1e31b0f1325


Jan

Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()

[Joel Brobecker]

> >> The related warning under Darwin x86_64:
> >> 
> >>   gcc -c -DHAVE_CONFIG_H    -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
> >>   ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
> >>     rl_message ("%s", p, 0);
> >>                 ~~~~     ^
> >>   1 warning generated.
> >> 
> >> 
> >> readline/ChangeLog.gdb:
> >> 
> >> 	* search.c (_rl_nsearch_init): Remove useless parameter '0' for
> >> 	rl_message().
> >
> > Because readline is a separate project from binutils/GDB, we prefer
> > it if you would first submit the patch to the readline project first
> > (bug-readline@gnu.org, in Cc: of this email), get it accepted there.
> 
> This bug was already fixed in bash 4.3.

I see! Sorry about the noise.  For my penance, I pushed the patch in.
Do we need it for 7.8.1 as well?

-- 
Joel

Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()

[Joel Brobecker]

> OK, thanks. But I do not understand the original sentence for:
> 
>   "Would you mind taking the lead in telling us when the patch is readline?"
> 
> Excuse me, I really have no any ideas about it, could you explain it for
> details?

What I meant by that is asking you to take charge of monitoring
the patch status and telling us when it is applied to readline,
so we do not have to do it for you. Since the patch had already
been applied there, this request no longer applies, so there is
nothing left that needs to be done.

-- 
Joel