From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31594 invoked by alias); 23 Sep 2014 10:59:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31573 invoked by uid 89); 23 Sep 2014 10:59:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 23 Sep 2014 10:59:01 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8NAwx7l027638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 23 Sep 2014 06:58:59 -0400 Received: from host2.jankratochvil.net (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8NAwtvU020697 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 23 Sep 2014 06:58:58 -0400 Date: Tue, 23 Sep 2014 10:59:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Doug Evans , "gdb-patches@sourceware.org" Subject: automated testing comment [Re: time to workaround libc/13097 in fsf gdb?] Message-ID: <20140923105855.GA10164@host2.jankratochvil.net> References: <5411CFAE.7040805@redhat.com> <20140912115452.GA5626@host2.jankratochvil.net> <5412E3AC.80203@redhat.com> <20140912123320.GA8704@host2.jankratochvil.net> <5412EB1F.40309@redhat.com> <20140917201049.GA22880@host2.jankratochvil.net> <541C3FCF.4000400@redhat.com> <541C409E.6010408@redhat.com> <20140920213033.GA6255@host2.jankratochvil.net> <541F2311.1040404@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <541F2311.1040404@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00675.txt.bz2 On Sun, 21 Sep 2014 21:12:17 +0200, Pedro Alves wrote: > On 09/20/2014 10:30 PM, Jan Kratochvil wrote: > > But for example kernel-2.6.32-220.el6.x86_64 is "prelinked", see below. > > Ah, didn't know that. That's the sort of thing we should have in > comments in the code, or at least in the commit log. That apparently would not work, comment is added only after the problem is discovered. It would be found by automated testing upon submitting patch for reviews, such as I have seen done through Jenkins connected to Gerrit. At least assuming the same "prelinked vDSO" (which is definitely not done by the prelink program) issue also happens on some non-Fedora/non-RHEL OSes (as Fedora/RHEL OSes have patched glibc where the vDSO is not listed in the link map at all and so the patch being discussed is not needed there). And sure deploying automated testing with the current GDB testsuite as is would not work now automatically as the testsuite has fuzzy results. Although at least running new testcases (from the patch under review) would work which would be sufficient in this case (but not in other cases - regression cases). Jan