From: Gary Benson <gbenson@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove support for "rtld_" prefix on solib-svr4 probes
Date: Fri, 26 Sep 2014 08:23:00 -0000 [thread overview]
Message-ID: <20140926082352.GA8237@blade.nx> (raw)
In-Reply-To: <87vbobe3yu.fsf@redhat.com>
Sergio Durigan Junior wrote:
> On Thursday, September 25 2014, Pedro Alves wrote:
> > The real point was that the user building GDB may have no control
> > over the system bits of the distro it is building GDB for (in this
> > case glibc's loader), just like when building for a proprietary
> > OS, even though GNU/Linux distros are based (mostly) on free
> > sources.
>
> Yeah, that is a fair point, and it is very valid when we talk about
> things that might make GDB break badly when removed. But in this
> case, we are talking about a very specific Fedora/RHEL thing, which
> is itself intended to improve something (i.e., GDB will still work
> without it on old Fedora/RHEL systems), so I think most of the
> concerns don't apply here.
The code is dead, but only recently so. It's still warm :)
Removing the prefixed-probes code would reintroduce this:
https://sourceware.org/bugzilla/show_bug.cgi?id=2328
My preference is to leave the prefixes in, at least for now; you don't
know what people are using out there. The comment lists affected OS
versions so future reviewers will be able to decide how relevant it
is.
I don't think we need to bother with prefix support in the testsuite,
but we should probably switch to a probe that GDB is using like Pedro
mentioned earlier. "reloc_complete" would be good.
Cheers,
Gary
--
http://gbenson.net/
prev parent reply other threads:[~2014-09-26 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 18:03 [RFA] Fix PR gdb/17016: Expect for probe "map_complete" instead of "rtld_map_complete" Sergio Durigan Junior
2014-09-25 9:41 ` Gary Benson
2014-09-25 10:38 ` Pedro Alves
2014-09-25 20:47 ` [PATCH] Remove support for "rtld_" prefix on solib-svr4 probes (was: Re: [RFA] Fix PR gdb/17016: Expect for probe "map_complete" instead of "rtld_map_complete") Sergio Durigan Junior
2014-09-25 21:13 ` [PATCH] Remove support for "rtld_" prefix on solib-svr4 probes Pedro Alves
2014-09-25 21:23 ` Sergio Durigan Junior
2014-09-25 21:44 ` Pedro Alves
2014-09-25 21:53 ` Sergio Durigan Junior
2014-09-25 22:07 ` Pedro Alves
2014-09-25 22:21 ` Sergio Durigan Junior
2014-09-26 8:23 ` Gary Benson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926082352.GA8237@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).