From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4974 invoked by alias); 26 Sep 2014 08:23:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4955 invoked by uid 89); 26 Sep 2014 08:23:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 26 Sep 2014 08:23:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8Q8NsIg032209 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 26 Sep 2014 04:23:54 -0400 Received: from blade.nx (ovpn-116-80.ams2.redhat.com [10.36.116.80]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8Q8NrTW005048 for ; Fri, 26 Sep 2014 04:23:53 -0400 Received: by blade.nx (Postfix, from userid 1000) id 8D0892622EC; Fri, 26 Sep 2014 09:23:52 +0100 (BST) Date: Fri, 26 Sep 2014 08:23:00 -0000 From: Gary Benson To: GDB Patches Subject: Re: [PATCH] Remove support for "rtld_" prefix on solib-svr4 probes Message-ID: <20140926082352.GA8237@blade.nx> References: <1411581801-19126-1-git-send-email-sergiodj@redhat.com> <5423F08B.1040409@redhat.com> <87bnq3h1gf.fsf_-_@redhat.com> <54248579.8030606@redhat.com> <87r3yzfl86.fsf@redhat.com> <54248CD1.8000801@redhat.com> <87eguzfju7.fsf@redhat.com> <54249203.3030607@redhat.com> <87vbobe3yu.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87vbobe3yu.fsf@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00765.txt.bz2 Sergio Durigan Junior wrote: > On Thursday, September 25 2014, Pedro Alves wrote: > > The real point was that the user building GDB may have no control > > over the system bits of the distro it is building GDB for (in this > > case glibc's loader), just like when building for a proprietary > > OS, even though GNU/Linux distros are based (mostly) on free > > sources. > > Yeah, that is a fair point, and it is very valid when we talk about > things that might make GDB break badly when removed. But in this > case, we are talking about a very specific Fedora/RHEL thing, which > is itself intended to improve something (i.e., GDB will still work > without it on old Fedora/RHEL systems), so I think most of the > concerns don't apply here. The code is dead, but only recently so. It's still warm :) Removing the prefixed-probes code would reintroduce this: https://sourceware.org/bugzilla/show_bug.cgi?id=2328 My preference is to leave the prefixes in, at least for now; you don't know what people are using out there. The comment lists affected OS versions so future reviewers will be able to decide how relevant it is. I don't think we need to bother with prefix support in the testsuite, but we should probably switch to a probe that GDB is using like Pedro mentioned earlier. "reloc_complete" would be good. Cheers, Gary -- http://gbenson.net/