From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19703 invoked by alias); 2 Oct 2014 15:00:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19683 invoked by uid 89); 2 Oct 2014 15:00:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 02 Oct 2014 15:00:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 268AD1162DD; Thu, 2 Oct 2014 11:00:33 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id O7fKpSIJH8D1; Thu, 2 Oct 2014 11:00:33 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DA271116216; Thu, 2 Oct 2014 11:00:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 30A1B497DD; Thu, 2 Oct 2014 08:00:34 -0700 (PDT) Date: Thu, 02 Oct 2014 15:00:00 -0000 From: Joel Brobecker To: Tobias Burnus Cc: gdb-patches@sourceware.org, sanimir.agovic@intel.com, Keven Boell Subject: Re: PING: [V3 00/21] Fortran dynamic array support Message-ID: <20141002150034.GF6927@adacore.com> References: <1410340929-20653-1-git-send-email-keven.boell@intel.com> <20141002083529.GA11298@physik.fu-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141002083529.GA11298@physik.fu-berlin.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-10/txt/msg00030.txt.bz2 > I would like to ping the Fortran patch series at > https://sourceware.org/ml/gdb-patches/2014-09/threads.html#00259 > > I think it would be useful if Sourceware's gdb would finally get > support for Fortran 90 arrays. > > The patch might be not as clean as hoped for,* but it is the best > what we currently have. Thus, I would be happy if someone could > review it. I started looking at them a while ago, but unfortunately I am in the middle of a lot of things, and I don't expect to have much time until probably Dec. My main issue about the patch series is that it adds new fields in struct type which are only used occasionally. The problem with that is that it is a memory-sensitive type, for which a lot of work has gone into making as small as possible. It would be OK if most instances were benefiting from it, but it's a lot less attractive when you know it's only occasionally non-null. Ideally, we'd want to keep the type structure untouched, so that only entities needing dynamic property handling get the size increase, and only for those attributes that are in fact dynamic. One idea I had was to manage that info right past the end of struct type. But that may be very hacky, and I am not sure if it is actually practical. The next idea is to add one pointer to handle all future dynamic props. Either way, I need to explore things a bit. Once we have the above figured out, one thing which I think would help a lot is modify the way the patches have been submitted. Instead of sending 20 patches, where we get a series of code changes followed by a series of testsuite changes, it would be useful to provide a testsuite change for every patch that brings an improvement. This way, the testsuite change shows what the patch does, and that way, I can review both changes at the same time. -- Joel