From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: sivachandra@google.com (Siva Chandra)
Cc: gdb-patches@sourceware.org (gdb-patches)
Subject: Re: [PATCH] PR c++/17494 - Fix evaluation of method calls under EVAL_SKIP
Date: Mon, 03 Nov 2014 15:08:00 -0000 [thread overview]
Message-ID: <201411031508.sA3F815b024788@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <CAGyQ6gxnfw6yRmMzGG2T5acqO2od7WL7-8F1wVRTp9mfNvg9Sg@mail.gmail.com> from "Siva Chandra" at Oct 20, 2014 12:11:45 PM
Siva Chandra wrote:
> When evaluating method calls under EVAL_SKIP, the "object" and the
> arguments to the method should also be evaluated under EVAL_SKIP,
> instead of skipping to evaluate them. Getting this right fixes PR
> c++/17494.
OK, this makes sense.
>gdb/ChangeLog:
>
>2014-10-20 Siva Chandra Reddy <sivachandra@google.com>
>
> PR c++/17494
> * eval.c (evaluate_subexp_standard): Evaluate the "object" and
> the method args also under EVAL_SKIP when evaluating method
> calls under EVAL_SKIP.
>
>gdb/testsuite/ChangeLog:
>
>2014-10-20 Siva Chandra Reddy <sivachandra@google.com>
>
> PR c++/17494
> * gdb.cp/pr17494.cc: New file.
> * gdb.cp/pr17494.exp: New file.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2014-11-03 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 19:11 Siva Chandra
2014-10-27 17:22 ` Siva Chandra
2014-11-03 14:35 ` Siva Chandra
2014-11-03 15:08 ` Ulrich Weigand [this message]
2014-11-04 2:08 ` Siva Chandra
2014-11-05 0:24 ` Alan Modra
2014-11-05 0:33 ` Siva Chandra
2014-11-05 11:00 ` James Greenhalgh
2014-11-05 12:54 ` Alan Modra
2014-11-10 14:24 ` [push] Work around GCC bug 63748 (Re: [PATCH] PR c++/17494 - Fix evaluation of method calls under EVAL_SKIP) Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411031508.sA3F815b024788@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).