From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31112 invoked by alias); 3 Nov 2014 15:08:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31098 invoked by uid 89); 3 Nov 2014 15:08:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: e06smtp16.uk.ibm.com Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 03 Nov 2014 15:08:09 +0000 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Nov 2014 15:08:06 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 3 Nov 2014 15:08:05 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 197C31B0804B for ; Mon, 3 Nov 2014 15:08:10 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sA3F84F45439942 for ; Mon, 3 Nov 2014 15:08:04 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sA3F83TK024930 for ; Mon, 3 Nov 2014 08:08:04 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id sA3F815b024788; Mon, 3 Nov 2014 08:08:01 -0700 Message-Id: <201411031508.sA3F815b024788@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 03 Nov 2014 16:08:01 +0100 Subject: Re: [PATCH] PR c++/17494 - Fix evaluation of method calls under EVAL_SKIP To: sivachandra@google.com (Siva Chandra) Date: Mon, 03 Nov 2014 15:08:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (gdb-patches) In-Reply-To: from "Siva Chandra" at Oct 20, 2014 12:11:45 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14110315-0025-0000-0000-00000238341B X-SW-Source: 2014-11/txt/msg00048.txt.bz2 Siva Chandra wrote: > When evaluating method calls under EVAL_SKIP, the "object" and the > arguments to the method should also be evaluated under EVAL_SKIP, > instead of skipping to evaluate them. Getting this right fixes PR > c++/17494. OK, this makes sense. >gdb/ChangeLog: > >2014-10-20 Siva Chandra Reddy > > PR c++/17494 > * eval.c (evaluate_subexp_standard): Evaluate the "object" and > the method args also under EVAL_SKIP when evaluating method > calls under EVAL_SKIP. > >gdb/testsuite/ChangeLog: > >2014-10-20 Siva Chandra Reddy > > PR c++/17494 > * gdb.cp/pr17494.cc: New file. > * gdb.cp/pr17494.exp: New file. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com