From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5216 invoked by alias); 21 Nov 2014 10:46:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5206 invoked by uid 89); 21 Nov 2014 10:46:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 21 Nov 2014 10:46:46 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sALAkgoq000648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 21 Nov 2014 05:46:42 -0500 Received: from blade.nx (ovpn-116-125.ams2.redhat.com [10.36.116.125]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sALAkfRu028637; Fri, 21 Nov 2014 05:46:42 -0500 Received: by blade.nx (Postfix, from userid 1000) id 438412626EA; Fri, 21 Nov 2014 10:46:41 +0000 (GMT) Date: Fri, 21 Nov 2014 10:46:00 -0000 From: Gary Benson To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3 v2] Implement completion limiting Message-ID: <20141121104641.GA25075@blade.nx> References: <1415271046-4957-1-git-send-email-gbenson@redhat.com> <1415271046-4957-4-git-send-email-gbenson@redhat.com> <83h9ycthsx.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83h9ycthsx.fsf@gnu.org> X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00506.txt.bz2 Eli Zaretskii wrote: > > From: Gary Benson > > Date: Thu, 6 Nov 2014 10:50:46 +0000 > > --- a/gdb/NEWS > > +++ b/gdb/NEWS > > OK for this part. > > > +void > > +_initialize_completer (void) > > +{ > > + add_setshow_zuinteger_unlimited_cmd ("max-completions", no_class, > > + &max_completions, _("\ > > +Set maximum number of line completion possibilities."), _("\ > > +Show maximum number of line completion possibilities."), _("\ > > I suggest to use "completion candidates" instead of "line completion > possibilities". > > > +Use this to limit the number of possibilities considered\n\ > > +during line completion. Specifying \"unlimited\" or -1\n\ > ^^^^^^^^^^^^^^^ > And here use just "completion". "Line completion" is IMO confusing, > since we don't complete "lines". > > > +@table @code > > +@kindex set max-completions > > +@item set max-completions @var{limit} > > +@itemx set max-completions unlimited > > +Set the maximum number of possibilities to be considered during > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > "Candidates to be shown" is better. > > > +completion. The default value is 200. Note that setting either > > +no limit or a very large limit can cause pauses during completion. > > Not "cause pauses", but rather "make completion slow", I think. > > > +@kindex show max-completions > > +@item show max-completions > > +Show the maximum number of possibilities to be considered during > > +completion. > > Suggest the same change here as above. > > The documentation part of the patch is OK with those changes. > > Thanks. Thanks Eli. Cheers, Gary -- http://gbenson.net/