From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14782 invoked by alias); 23 Nov 2014 10:17:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14754 invoked by uid 89); 23 Nov 2014 10:17:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 23 Nov 2014 10:17:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C337E1167E3; Sun, 23 Nov 2014 05:17:35 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ImZlyopOHIey; Sun, 23 Nov 2014 05:17:35 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6419B11664F; Sun, 23 Nov 2014 05:17:35 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9B52940F79; Sun, 23 Nov 2014 14:17:34 +0400 (RET) Date: Sun, 23 Nov 2014 10:17:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Remove files in make clean Message-ID: <20141123101734.GF7136@adacore.com> References: <1416224764-5607-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416224764-5607-1-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00564.txt.bz2 > I am looking at how 'make clean' in testsuite/ directory remove files > generated during testing. We manually maintain a list of > executables and shared libraries in Makefile.in, and they are removed > in 'make clean'. However, the list will be stale as the code evolves. > I am wondering a better approach than the current one. I find > that name of most the executables is the same as the name of .exp or > .c file, so I modify clean target in testsuite/Makefile.in to delete > executables according to the name of .exp and .c file, in a > speculative way. As a result, the manually maintained list in > testsuite/gdb.XXX/Makefile.in is shorter, only executables, which are > not covered by the speculation, should be listed. So this approach > is a hybrid approach, that is most of the executables can be removed, > without any special care and special care is needed for the rest of them. > > This is a RFC, because I'd like ask people's opinion on this. If it > is good, I'll update other gdb.XXX/Makefile.in. > > gdb/testsuite: > > 2014-11-17 Yao Qi > > * Makefile.in (clean): Remove files according to .exp and .c > file name in srcdir. > * gdb.base/Makefile.in (EXECUTABLES): Remove some entries. FWIW, I think we should give it a try, and see how well this works in practice. I agree with Yao that this is an issue (one that I have given up on, especially since I moved to out-of-tree builds). -- Joel