From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v4 11/14] export dwarf2_reg_to_regnum_or_error
Date: Sun, 23 Nov 2014 19:28:00 -0000 [thread overview]
Message-ID: <20141123192840.32193.82078.stgit@host1.jankratochvil.net> (raw)
In-Reply-To: <20141123192713.32193.57150.stgit@host1.jankratochvil.net>
This exports a utility function, dwarf2_reg_to_regnum_or_error, that
was previously private to dwarf2loc.c.
2014-10-07 Jan Kratochvil <jan.kratochvil@redhat.com>
* dwarf2loc.h (dwarf2_reg_to_regnum_or_error): Declare.
* dwarf2loc.c (dwarf2_reg_to_regnum_or_error): Rename from
translate_register. Now public.
(dwarf2_compile_expr_to_ax): Update.
---
gdb/ChangeLog | 7 +++++++
gdb/dwarf2loc.c | 18 +++++++-----------
gdb/dwarf2loc.h | 8 ++++++++
3 files changed, 22 insertions(+), 11 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bf9daed..02c28b2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2014-10-07 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * dwarf2loc.h (dwarf2_reg_to_regnum_or_error): Declare.
+ * dwarf2loc.c (dwarf2_reg_to_regnum_or_error): Rename from
+ translate_register. Now public.
+ (dwarf2_compile_expr_to_ax): Update.
+
2014-10-07 Tom Tromey <tromey@redhat.com>
Jan Kratochvil <jan.kratochvil@redhat.com>
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index 50c2f24..d30b72f 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -2707,14 +2707,10 @@ unimplemented (unsigned int op)
op);
}
-/* A helper function to convert a DWARF register to an arch register.
- ARCH is the architecture.
- DWARF_REG is the register.
- This will throw an exception if the DWARF register cannot be
- translated to an architecture register. */
+/* See dwarf2loc.h. */
-static int
-translate_register (struct gdbarch *arch, int dwarf_reg)
+int
+dwarf2_reg_to_regnum_or_error (struct gdbarch *arch, int dwarf_reg)
{
int reg = gdbarch_dwarf2_reg_to_regnum (arch, dwarf_reg);
if (reg == -1)
@@ -2965,14 +2961,14 @@ dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc,
case DW_OP_reg30:
case DW_OP_reg31:
dwarf_expr_require_composition (op_ptr, op_end, "DW_OP_regx");
- loc->u.reg = translate_register (arch, op - DW_OP_reg0);
+ loc->u.reg = dwarf2_reg_to_regnum_or_error (arch, op - DW_OP_reg0);
loc->kind = axs_lvalue_register;
break;
case DW_OP_regx:
op_ptr = safe_read_uleb128 (op_ptr, op_end, ®);
dwarf_expr_require_composition (op_ptr, op_end, "DW_OP_regx");
- loc->u.reg = translate_register (arch, reg);
+ loc->u.reg = dwarf2_reg_to_regnum_or_error (arch, reg);
loc->kind = axs_lvalue_register;
break;
@@ -3035,7 +3031,7 @@ dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc,
case DW_OP_breg30:
case DW_OP_breg31:
op_ptr = safe_read_sleb128 (op_ptr, op_end, &offset);
- i = translate_register (arch, op - DW_OP_breg0);
+ i = dwarf2_reg_to_regnum_or_error (arch, op - DW_OP_breg0);
ax_reg (expr, i);
if (offset != 0)
{
@@ -3047,7 +3043,7 @@ dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc,
{
op_ptr = safe_read_uleb128 (op_ptr, op_end, ®);
op_ptr = safe_read_sleb128 (op_ptr, op_end, &offset);
- i = translate_register (arch, reg);
+ i = dwarf2_reg_to_regnum_or_error (arch, reg);
ax_reg (expr, i);
if (offset != 0)
{
diff --git a/gdb/dwarf2loc.h b/gdb/dwarf2loc.h
index 082ccfa..76fb45b4 100644
--- a/gdb/dwarf2loc.h
+++ b/gdb/dwarf2loc.h
@@ -222,4 +222,12 @@ extern struct call_site_chain *call_site_find_chain (struct gdbarch *gdbarch,
CORE_ADDR caller_pc,
CORE_ADDR callee_pc);
+/* A helper function to convert a DWARF register to an arch register.
+ ARCH is the architecture.
+ DWARF_REG is the register.
+ This will throw an exception if the DWARF register cannot be
+ translated to an architecture register. */
+
+extern int dwarf2_reg_to_regnum_or_error (struct gdbarch *arch, int dwarf_reg);
+
#endif /* dwarf2loc.h */
next prev parent reply other threads:[~2014-11-23 19:28 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 19:27 [PATCH v4 00/14] let gdb reuse gcc's C compiler Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 01/14] introduce ui_file_write_for_put Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 04/14] add make_unqualified_type Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 03/14] add some missing ops to DWARF assembler Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 02/14] add gcc/gdb interface files Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 07/14] add gnu_triplet_regexp gdbarch method Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 10/14] make dwarf_expr_frame_base_1 public Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 08/14] introduce call_function_by_hand_dummy Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 12/14] add linux_infcall_mmap Jan Kratochvil
2014-12-15 12:41 ` Ulrich Weigand
2014-12-15 13:49 ` Yao Qi
2014-12-15 16:48 ` Jan Kratochvil
2014-12-16 5:27 ` Yao Qi
2014-11-23 19:28 ` Jan Kratochvil [this message]
2014-11-23 19:28 ` [PATCH v4 13/14] add s390_gcc_target_options Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 05/14] add dummy frame destructor Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 09/14] split dwarf2_fetch_cfa_info from dwarf2_compile_expr_to_ax Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 06/14] add infcall_mmap and gcc_target_options gdbarch methods Jan Kratochvil
2014-11-23 19:29 ` [PATCH v4 14/14] the "compile" command Jan Kratochvil
2014-12-14 6:05 ` Yao Qi
2014-12-14 7:53 ` Jan Kratochvil
2014-12-14 8:54 ` Yao Qi
2014-12-14 18:24 ` [mingw rfc] Add mkdtemp to gdb/gnulib/ [Re: [PATCH v4 14/14] the "compile" command] Jan Kratochvil
2014-12-15 3:16 ` Yao Qi
2014-12-15 12:44 ` Joel Brobecker
2014-12-15 13:11 ` Kai Tietz
2014-12-15 13:24 ` Yao Qi
2014-12-15 17:12 ` Jan Kratochvil
2014-12-15 17:48 ` Eli Zaretskii
2014-12-15 18:14 ` Joel Brobecker
2014-12-15 18:21 ` Jan Kratochvil
2014-12-15 18:35 ` Joel Brobecker
2014-12-15 18:40 ` Jan Kratochvil
2014-12-15 18:57 ` Eli Zaretskii
2014-12-15 22:28 ` [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/] Jan Kratochvil
2014-12-15 22:56 ` Jan Kratochvil
2014-12-16 3:40 ` Eli Zaretskii
2014-12-16 9:04 ` Kai Tietz
2014-12-17 21:02 ` [patch] compile: rm -rf -> ftw()+rmdir()+unlink() [Re: [patch] compile: Fix MinGW build] Jan Kratochvil
2014-12-17 22:07 ` Steve Ellcey
2014-12-17 22:42 ` Pedro Alves
2014-12-18 18:14 ` Jan Kratochvil
2014-12-18 18:24 ` Pedro Alves
2014-12-18 18:41 ` Jan Kratochvil
2014-12-18 19:07 ` Pedro Alves
2014-12-18 21:05 ` Jan Kratochvil
2014-12-18 21:11 ` Eli Zaretskii
2014-12-18 21:24 ` Jan Kratochvil
2014-12-18 22:18 ` Sergio Durigan Junior
2014-12-18 23:06 ` Pedro Alves
2014-12-19 0:12 ` Jan Kratochvil
2014-12-19 10:48 ` Pedro Alves
2014-12-19 8:24 ` Eli Zaretskii
2014-12-19 12:59 ` Joel Brobecker
2014-12-18 20:26 ` Eli Zaretskii
2014-12-18 5:38 ` Yao Qi
2014-12-18 17:23 ` Eli Zaretskii
2014-12-18 17:31 ` Jan Kratochvil
2014-12-18 17:40 ` Eli Zaretskii
2014-12-18 20:15 ` Kai Tietz
2014-12-18 20:47 ` Eli Zaretskii
2014-12-18 20:55 ` Kai Tietz
2014-12-18 23:47 ` Pedro Alves
2014-12-19 9:28 ` Kai Tietz
2014-12-19 19:25 ` Jan Kratochvil
2014-12-19 20:55 ` Jan Kratochvil
2014-12-20 12:26 ` Joel Brobecker
2014-12-18 20:56 ` Sergio Durigan Junior
2014-12-17 17:30 ` [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/] Steve Ellcey
2014-12-16 3:37 ` Eli Zaretskii
2014-12-16 9:06 ` Kai Tietz
2014-12-17 19:18 ` Jan Kratochvil
2014-12-17 19:31 ` Eli Zaretskii
2014-12-17 19:37 ` Jan Kratochvil
2014-12-17 20:34 ` Pedro Alves
2014-12-18 17:22 ` Eli Zaretskii
2014-12-18 18:00 ` Pedro Alves
2014-12-16 12:40 ` Pierre Muller
2014-12-17 18:21 ` Jan Kratochvil
2014-12-17 1:22 ` Yao Qi
2014-12-17 10:57 ` Pedro Alves
2014-12-17 11:40 ` Yao Qi
2014-12-17 11:43 ` Pedro Alves
2014-12-17 11:56 ` Yao Qi
2014-12-17 19:15 ` Jan Kratochvil
2014-12-17 11:16 ` Pedro Alves
2014-12-17 18:17 ` [patchv2] " Jan Kratochvil
2014-12-17 18:33 ` Pedro Alves
2014-12-17 19:12 ` [commit] " Jan Kratochvil
2014-12-05 18:29 ` [patch 15/14] GDB/GCC compile function pointers [Re: [PATCH v4 00/14] let gdb reuse gcc's C compiler] Jan Kratochvil
2014-12-12 21:51 ` obsolete: " Jan Kratochvil
2014-12-12 14:40 ` [PATCH v4 00/14] let gdb reuse gcc's C compiler Pedro Alves
2014-12-12 21:46 ` [commit all 14 parts] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141123192840.32193.82078.stgit@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).